Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo rfc80 poc violin plot #10863

Merged
merged 10 commits into from
Jul 2, 2024
Merged

Conversation

uklineale
Copy link
Contributor

@uklineale uklineale commented Jun 25, 2024

Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • migrate violin plot to Clickhouse
  • Reduced time by 9x (44s -> 5s) on GENIE dataset

Checks

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

@uklineale uklineale requested review from JREastonMarks, haynescd and alisman and removed request for JREastonMarks June 25, 2024 20:48
@haynescd
Copy link
Collaborator

@uklineale you got a few sonar cloud issues to resolve

@haynescd
Copy link
Collaborator

can you profile this and see where the bottle neck still is?

10s is still pretty large

@uklineale
Copy link
Contributor Author

After working with Charles, we were able to reduce the time to 5s. Further improvements need to be made to the database to speed up this endpoint.

Copy link

Copy link
Collaborator

@haynescd haynescd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@haynescd haynescd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haynescd haynescd merged commit 2e02f21 into demo-rfc80-poc Jul 2, 2024
15 of 19 checks passed
@haynescd haynescd deleted the demo-rfc80-poc-violin_plot branch July 2, 2024 13:52
haynescd pushed a commit that referenced this pull request Nov 25, 2024
* refactor to use clickhouse

* filter out empty attr values

* edit comment

* fix sonarcloud issues

* use parallel stream, shaves off 5s

* use newer mapping annotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants