Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo rfc80 density plot #10837

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

uklineale
Copy link
Contributor

Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • Use clickhouse for density plot calls
  • Refactor logic into service to clean up controller
  • Simplify logic into Java streams

Checks

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

Copy link
Collaborator

@haynescd haynescd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haynescd
Copy link
Collaborator

Great Job @uklineale

@haynescd haynescd merged commit 1d1606b into cBioPortal:demo-rfc80-poc Jun 18, 2024
8 of 12 checks passed
@uklineale uklineale deleted the demo-rfc80-density_plot branch June 20, 2024 14:06
haynescd pushed a commit that referenced this pull request Nov 25, 2024
* working poc

* refactor logic into service, so clean

* refactor for parameters builder, simplify min max logic, streamline service call

* remove unused services and imports

* remove more unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants