-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo rfc80 density plot #10837
Merged
haynescd
merged 5 commits into
cBioPortal:demo-rfc80-poc
from
uklineale:demo-rfc80-density_plot
Jun 18, 2024
Merged
Demo rfc80 density plot #10837
haynescd
merged 5 commits into
cBioPortal:demo-rfc80-poc
from
uklineale:demo-rfc80-density_plot
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
reviewed
Jun 17, 2024
src/main/java/org/cbioportal/service/impl/ClinicalDataDensityPlotServiceImpl.java
Outdated
Show resolved
Hide resolved
haynescd
reviewed
Jun 18, 2024
src/main/java/org/cbioportal/service/ClinicalDataDensityPlotService.java
Outdated
Show resolved
Hide resolved
haynescd
reviewed
Jun 18, 2024
src/main/java/org/cbioportal/web/columnar/StudyViewColumnStoreController.java
Outdated
Show resolved
Hide resolved
haynescd
reviewed
Jun 18, 2024
src/main/java/org/cbioportal/service/ClinicalDataDensityPlotService.java
Outdated
Show resolved
Hide resolved
3 tasks
haynescd
reviewed
Jun 18, 2024
src/main/java/org/cbioportal/web/columnar/StudyViewColumnStoreController.java
Outdated
Show resolved
Hide resolved
haynescd
reviewed
Jun 18, 2024
src/main/java/org/cbioportal/web/columnar/StudyViewColumnStoreController.java
Outdated
Show resolved
Hide resolved
haynescd
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Great Job @uklineale |
haynescd
pushed a commit
that referenced
this pull request
Nov 25, 2024
* working poc * refactor logic into service, so clean * refactor for parameters builder, simplify min max logic, streamline service call * remove unused services and imports * remove more unused imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)
Describe changes proposed in this pull request:
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>
to determine thatand notify them either through slack or by assigning them as a reviewer on the PR