Fix disabling SSL for MySQL connection #10353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from #10276
Fix #10275
Problem
When migrating the database the migration.py script tries to connect to the MySQL database over SSL, despite the db.use_ssl property having value false.
Analysis
The current and broken logic in migration.py to configure SSL is:
When I change this to the following, the db.use_ssl property is respected:
Changes in this PR
This PR will add the ssl_mode to the kwargs of the migration script.