Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GSoC) Generic Assay Categorical/Binary data implementation Backend #10303

Merged
merged 41 commits into from
Aug 18, 2023
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
f4b15fb
update backend
Djokovic0311 Jun 28, 2023
06d2699
finish tests
Djokovic0311 Jul 26, 2023
f46960b
modify controller file structure
Djokovic0311 Aug 8, 2023
79e44b4
modify import
Djokovic0311 Aug 8, 2023
99357cb
update backend
Djokovic0311 Jun 28, 2023
e1166ea
finish tests
Djokovic0311 Jul 26, 2023
93f4fc3
modify controller file structure
Djokovic0311 Aug 8, 2023
0ab23a6
refactor some variables
Djokovic0311 Aug 8, 2023
7b94ec3
modify enrichment compare and validate issue
Djokovic0311 Aug 8, 2023
63e9f99
refactor the controllers and services
Djokovic0311 Aug 8, 2023
aa229fc
refactor test
Djokovic0311 Aug 8, 2023
8569262
Update GenericAssayEnrichmentServiceImpl.java
Djokovic0311 Aug 8, 2023
34635ec
fixed simplification issues
Djokovic0311 Aug 11, 2023
36a2842
add inline comments
Djokovic0311 Aug 11, 2023
fa6e739
modify import
Djokovic0311 Aug 11, 2023
46344b0
solve core test issue
Djokovic0311 Aug 11, 2023
6bccdb9
test check
Djokovic0311 Aug 13, 2023
b142014
modify expressionenrichment
Djokovic0311 Aug 13, 2023
732f24e
modify imports
Djokovic0311 Aug 16, 2023
78ed825
update backend
Djokovic0311 Jun 28, 2023
203ca2a
finish tests
Djokovic0311 Jul 26, 2023
4775550
modify controller file structure
Djokovic0311 Aug 8, 2023
ef5a474
modify import
Djokovic0311 Aug 8, 2023
2cc1329
update backend
Djokovic0311 Jun 28, 2023
6d9896b
finish tests
Djokovic0311 Jul 26, 2023
e26844e
modify controller file structure
Djokovic0311 Aug 8, 2023
4571b26
refactor some variables
Djokovic0311 Aug 8, 2023
6be68ef
modify enrichment compare and validate issue
Djokovic0311 Aug 8, 2023
54c8cc3
refactor the controllers and services
Djokovic0311 Aug 8, 2023
74bd2ae
refactor test
Djokovic0311 Aug 8, 2023
5bc13aa
Update GenericAssayEnrichmentServiceImpl.java
Djokovic0311 Aug 8, 2023
fa8d5ec
fixed simplification issues
Djokovic0311 Aug 11, 2023
fe2acc8
add inline comments
Djokovic0311 Aug 11, 2023
7a473ed
modify import
Djokovic0311 Aug 11, 2023
ca00f33
solve core test issue
Djokovic0311 Aug 11, 2023
1f9dfb0
test check
Djokovic0311 Aug 13, 2023
ab59702
modify expressionenrichment
Djokovic0311 Aug 13, 2023
13ea407
modify imports
Djokovic0311 Aug 16, 2023
7bf56d2
Merge branch 'GenericAssay-Jiahang' of https://github.com/Djokovic031…
Djokovic0311 Aug 16, 2023
24158cd
update imports
Djokovic0311 Aug 16, 2023
b51a6e3
Update GenericAssayEnrichment.java
Djokovic0311 Aug 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package org.cbioportal.model;

import javax.validation.constraints.NotNull;
import java.math.BigDecimal;
import java.util.List;

public class GenericAssayBinaryEnrichment extends GenericAssayEnrichment {
@NotNull
private List<GenericAssayCountSummary> counts;

public List<GenericAssayCountSummary> getCounts() {
return counts;
}

public void setCounts(List<GenericAssayCountSummary> counts) {
this.counts = counts;
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package org.cbioportal.model;

import javax.validation.constraints.NotNull;
import java.math.BigDecimal;

public class GenericAssayCategoricalEnrichment extends GenericAssayEnrichment {
@NotNull
private BigDecimal qValue;

public BigDecimal getqValue() {
return qValue;
}

public void setqValue(BigDecimal qValue) {
this.qValue = qValue;
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
package org.cbioportal.model;

import javax.validation.constraints.NotNull;
import java.io.Serializable;

public class GenericAssayCountSummary implements Serializable {

@NotNull
private String name;
@NotNull
private Integer count;
@NotNull
private Integer totalCount;

public Integer getCount() {
return count;
}

public void setCount(Integer count) {
this.count = count;
}

public String getName() {
return name;
}

public void setName(String name) {
this.name = name;
}

public Integer getTotalCount() {
return totalCount;
}

public void setTotalCount(Integer totalCount) {
this.totalCount = totalCount;
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.cbioportal.model;

import java.io.Serializable;
import java.math.BigDecimal;
import java.util.HashMap;

import javax.validation.constraints.NotNull;
Expand All @@ -11,6 +12,8 @@ public class GenericAssayEnrichment extends ExpressionEnrichment implements Seri
private String stableId;
@NotNull
private String name;
@NotNull
private BigDecimal qValue;
@NotNull
private HashMap<String, String> genericEntityMetaProperties;

Expand Down Expand Up @@ -38,4 +41,14 @@ public void setGenericEntityMetaProperties(HashMap<String, String> genericEntity
this.genericEntityMetaProperties = genericEntityMetaProperties;
}

public static int compare(GenericAssayEnrichment c1, GenericAssayEnrichment c2) {
return c1.getpValue().compareTo(c2.getpValue());
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a new line between the two methods? Also maybe better to put compare method after setqValue method.

public BigDecimal getqValue() {
return qValue;
}

public void setqValue(BigDecimal qValue) {
this.qValue = qValue;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
import org.cbioportal.model.GenericAssayEnrichment;
import org.cbioportal.model.GenomicEnrichment;
import org.cbioportal.model.MolecularProfileCaseIdentifier;
import org.cbioportal.model.GenericAssayBinaryEnrichment;
import org.cbioportal.model.GenericAssayCategoricalEnrichment;
import org.cbioportal.service.exception.MolecularProfileNotFoundException;

public interface ExpressionEnrichmentService {
Expand All @@ -15,8 +17,18 @@ List<GenomicEnrichment> getGenomicEnrichments(String molecularProfileId,
Map<String, List<MolecularProfileCaseIdentifier>> molecularProfileCaseSets, EnrichmentType enrichmentType)
throws MolecularProfileNotFoundException;

List<GenericAssayEnrichment> getGenericAssayEnrichments(String molecularProfileId,
List<GenericAssayEnrichment> getGenericAssayNumericalEnrichments(String molecularProfileId,
Map<String, List<MolecularProfileCaseIdentifier>> molecularProfileCaseSets, EnrichmentType enrichmentType)
throws MolecularProfileNotFoundException;
List<GenericAssayBinaryEnrichment> getGenericAssayBinaryEnrichments(
String molecularProfileId,
Map<String, List<MolecularProfileCaseIdentifier>> molecularProfileCaseSets,
EnrichmentType enrichmentType)
throws MolecularProfileNotFoundException;

List<GenericAssayCategoricalEnrichment> getGenericAssayCategoricalEnrichments(String molecularProfileId,
Map<String, List<MolecularProfileCaseIdentifier>> molecularProfileCaseSets,
EnrichmentType enrichmentType)
throws MolecularProfileNotFoundException;

}

Large diffs are not rendered by default.

Loading