-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve keycloak configuration docs #10238
Conversation
- document url to download IDP SSO descriptor xml file. - add complete logback xml file example to turn on DEBUG level - document how to bind mount the logback xml file to docker container - document what role name stands for when filter_groups_by_appname=false/true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @forus , this is a great improvement 👍
...oyment/authorization-and-authentication/Authenticating-and-Authorizing-Users-via-keycloak.md
Outdated
Show resolved
Hide resolved
...oyment/authorization-and-authentication/Authenticating-and-Authorizing-Users-via-keycloak.md
Outdated
Show resolved
Hide resolved
Co-authored-by: pieterlukasse <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
@n1zea144 @jagnathan This seems a good improvement to our current keycloak documentation, could we get your review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Improve keycloak configuration docs - document url to download IDP SSO descriptor xml file. - add complete logback xml file example to turn on DEBUG level - document how to bind mount the logback xml file to docker container - document what role name stands for when filter_groups_by_appname=false/true Co-authored-by: Ruslan Forostianov <[email protected]> Co-authored-by: pieterlukasse <[email protected]>
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>
to determine thatand notify them either through slack or by assigning them as a reviewer on the PR