Do not call next study view filter when no samples left #10124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvannierop
requested review from
haynescd,
alisman and
dippindots
and removed request for
haynescd
dippindots
approved these changes
Apr 12, 2023
|
Kudos, SonarCloud Quality Gate passed! |
JREastonMarks
added a commit
that referenced
this pull request
Aug 22, 2023
* fix #9461 - mutations api endpoint - modified java files to remove unused properties and changes to tests - db changes, mutationmapper.xml - Update seed_mini.sql roll back changes for refseqMrnaId roll back changes for refseqMrnaId Update ExtendedMutation.java Added required property setOncotatorRefseqMrnaId and getOncotatorRefseqMrnaId * Updated more files for removed fields Updated more files for removed fields Remove unused oncotator fields Remove unused oncotator fields ONCOTATOR_DBSNP_RS ONCOTATOR_UNIPROT_ENTRY_NAME remove fields from sql file ONCOTATOR_DBSNP_RS and ONCOTATOR_UNIPROT_ENTRY_NAME removal from sql file * db changes and renaming the column prefixes from oncotator to mutation db changes in sql for renaming columns renamed the column prefixes from oncotator to mutation on multiple classes and files * Update SQL statements Update testSql.sql updating testSql for the name change of columns from ONCOTATOR to MUTATION Update DaoMutation.java The data files still use the old column prefix of ONCOTATOR instead of MUTATION Update DaoMutation.java Update migration.sql Adding quotes around column names * db changes and renaming the column prefixes from oncotator to mutation db changes in sql for renaming columns renamed the column prefixes from oncotator to mutation on multiple classes and files * Update migration.sql Update migration.sql fix syntax errors in mysql change column Update migration.sql fix syntax errors in mysql change column setting db version setting db version * Removed Link columns Removed Link columns and modified the documentation * Update news.md * update news.md * update cosmic importer for new cosmic datafiles * Update DB version and renaming mutation_event fields * Update Mutation model * Update SQL to fix incompatibility with sqlmode OnlyFullGroupBy and add support for multiple database impls to support mysql and h2 * Allow binning and filtering of custom (numerical and categorical) data * Several small fixes and cleanup after feedback @dippindots * Remove excess whitespace * Fix combined Entrez Gene Id and Stuct Var Query in StructuralVariantMapper.xml * update bilkent members * Frontend v5.3.0 * Update ClinicalEventMyBatisRepositoryTest.java We need to update this test because it's not java 8 compatible. * Address java8 compatible issues in more tests * Add importer and validator section to release-drafter.yml * Fix release-drafter.yml error * Update news.md * Frontend v5.3.1 * Update News.md * Use custom driver annotations in sv counts * Test custom driver annotations filter in sv count query * Differentiate between test svs by making annotations unique * Fix sv whereSite1IsNot2 clause, add es0 sv custom driver data * Remove unused DriverManagerDataSource fields from db tests * Add comment to mybatis sv whereSite1IsNot2 clause * Fix validation result_report.html: include new sv * Frontend v5.3.2 * Update News.md * fixed swagger page validation errors * Frontend v5.3.3 * Add MSK database migration documentation (#10115) Co-authored-by: Ino de Bruijn <[email protected]> * Do not call next study view filter when no samples left (#10124) * Add studyId to CancerStudyTag entity * Frontend v5.3.4 * 🔧 Add Configuration Properties for study view summary limits * add sitemaps for retype adding url should fix this * Frontend v5.3.5 * Add tutorials from others * Add Farhan Haq tutorial video * 🔧 Add StudyDownloadUrl to portal.properties * Frontend v5.3.6 * Update News-Genie.md * Fix study tag search when no studies present * Add dsnparse Python requirement Needed for future PR concerning using db.connection_string to connect to the database * add jeremy to about page * Documentation markdown fixes (#10186) * Fix broken hyperlink to retype * Move development files under development directory * Fix markdown links for table of contents * Frontend v5.3.7 * Update gene set version and update tests * Fix integration test * Frontend v5.3.8 * 📚 Update Priority Documentation * ✨ Add ability to set priority to -1 for clinical attr * add statistical tests in FAQ Fixed #10198 * extend File-Formats.md with mutational signature datatype (#10172) * Frontend v5.3.9 * change docker compose cmds * fix contact email in dev section * fix release notes docs link * fix release procedure info * Frontend v5.3.10 * Add note about official releases * Add AACR GENIE BPC tutorial videos (#10215) * Adding new features news (#10149) * Adding new features news from 2022/05 to current Co-authored-by: Ino de Bruijn <[email protected]> * Update web-API-and-Clients.md (#10209) Add description of cbioportalR in web API section * Frontend v5.3.11 * Paginate clinical table response using Page and Pagable spring interfaces * Use PaginatedClinicalData * Add query to count items in clinical table * Replace spring page with page response headers * Fix page size when sorting clinical table * Sort clinical table by sample and patient ID * Fix distinct in patient attr sorting * Fix difference h2 and mysql in sorting nulls last * Rename *SampleClinicalTable* methods * update members about us page add calla & bryan, move several people to alumni * Revert controler rename to keep backward compatible * Impl. Struct Var count endpoint for Study View * Remove unused imports PR feedback Gaofei * Correct variable name PR feedback Gaofei * Change HashMap to Set PR feedback Gaofei * Return counts when gene 1 or gene2 is null * Change missing site1 or site2 gene for SV to INFO log level Was WARN before. * Update result report * Create property to show reference genome in study list * Frontend v5.3.12 * fix contributor last name * Frontend v5.3.13 * Impl. Struct Var filter queries for /filtered-samples/fetch endpoint * Add unit tests for resolveEntrezGeneIds * Changes after PR reviews - Rename StructVar* to StructuralVariant* - Revert JsonInclude Always to NON_NULL - * Add Java 11 as requirement * modify documentation for skin.hide_download_controls * Improve treatment data api performance * Improve study view treatment api performance * Update download control options (#10264) * Add more tests and comments * fix 10221 - 403 issue fix 10221 - 403 issue; swagger annotations cause issue in authentication object. If user authorization is enabled, authentication object is obtained from SecurityContextHolder * Update Pyyaml package See yaml/pyyaml#724 for details of this update * Frontend v5.3.14 * Changes related to download group * Allow ProfiledCasesCounter to add counts to empty alteration count list (#10255) * Update about us page * Frontend v5.3.15 * Cache treatment endpoints (#10282) * update one-sided fisher test to two-sided * Allow redis service unavailable when Redis is enabled * Frontend v5.3.16 * Update two-sided fisher tests news (#10312) * Add two-sided fisher tests news --------- Co-authored-by: Ino de Bruijn <[email protected]> * Genomic data counts study-view endpoint (#10300) * implement getting CNA types for a gene specific * add tests for genomic-data-counts endpoint * change CopyNumberDataCounterFilter to StudyViewFilter and GenomicDataCountFilter * change to molecularDataService to fetch data * add filter logic for DISCRETE molecular profiles * Refactor * count NA and clean up codes * Updates * Update StudyViewServiceImplTest.java --------- Co-authored-by: Qi-Xuan Lu <[email protected]> Co-authored-by: Karthik <[email protected]> * Frontend v5.3.17 * Add defaults for genomic evolution tab in patient view (#10309) * Add defaults for mutation heatmap and line chart checkboxes * Update text --------- Co-authored-by: Gaofei Zhao <[email protected]> * Add data access token user role filter feature (#10315) * Add data access token user role filter feature * Update and more tests * Update failing test --------- Co-authored-by: Jeremy R. Easton-Marks <[email protected]> * Update About-Us.md (#10196) Update About-Us.md * Add label check test for pull request * Frontend v5.3.18 * add info about adding labels * add property show_web_tours (#10333) * (GSoC) Generic Assay Categorical/Binary data implementation Backend (#10303) * update backend * finish tests * modify controller file structure * modify import * update backend * finish tests * modify controller file structure * refactor some variables * modify enrichment compare and validate issue * refactor the controllers and services * refactor test * Update GenericAssayEnrichmentServiceImpl.java * fixed simplification issues * add inline comments * modify import * solve core test issue * test check * modify expressionenrichment * modify imports * update backend * finish tests * modify controller file structure * modify import * update backend * finish tests * modify controller file structure * refactor some variables * modify enrichment compare and validate issue * refactor the controllers and services * refactor test * Update GenericAssayEnrichmentServiceImpl.java * fixed simplification issues * add inline comments * modify import * solve core test issue * test check * modify expressionenrichment * modify imports * update imports * Update GenericAssayEnrichment.java --------- Co-authored-by: Prasanna Kumar Jagannathan <[email protected]> Co-authored-by: sbabyanusha <[email protected]> Co-authored-by: matthijspon <[email protected]> Co-authored-by: Gaofei <[email protected]> Co-authored-by: haynescd <[email protected]> Co-authored-by: Charles Haynes <[email protected]> Co-authored-by: Pim van Nierop <[email protected]> Co-authored-by: Bas Leenknegt <[email protected]> Co-authored-by: Ino de Bruijn <[email protected]> Co-authored-by: sbabyanusha <[email protected]> Co-authored-by: John Konecny <[email protected]> Co-authored-by: alisman <[email protected]> Co-authored-by: ritikakundra <[email protected]> Co-authored-by: Tali Mazor <[email protected]> Co-authored-by: Justin Jao <[email protected]> Co-authored-by: JJ Gao <[email protected]> Co-authored-by: Matthijs Pon <[email protected]> Co-authored-by: karissawhiting <[email protected]> Co-authored-by: oplantalech <[email protected]> Co-authored-by: Onur Sumer <[email protected]> Co-authored-by: Qi-Xuan Lu <[email protected]> Co-authored-by: Karthik <[email protected]> Co-authored-by: Bryan Lai <[email protected]> Co-authored-by: qi-xuan.lu <[email protected]> Co-authored-by: Beking0912 <[email protected]> Co-authored-by: Jiahang Li <[email protected]>
jagnathan
pushed a commit
to pughlab/cbioportal
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix MySQL query errors when the manual submit mode of Study View is active and subsequent filters act on a list of zero samples due to previous filters.