-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use property/env variable to specify frontend version #2778
Comments
@inodb I have mixed feelings about this. On one hand, it's a good idea to free frontend from backend. On the other hand, the frontend is still tightly connected to the current Once we discard the |
@jjgao I think it would be very useful for review on Heroku at the moment. Currently we do the same thing during development using our If we are going to expand the use of this feature to other portal maintainers I agree that it would be better to first have better warning messages when the frontend & api mismatch. |
@inodb maybe in addition to the checked in version, we can support it in props file (which overrides the checked-in one)? We don't have to document it in order to keep it just for dev purposes for now. |
@jjgao yes, exactly |
This allows us to specify what cbioportal-frontend url should be used. It overrides whatever frontend version is provided in the WAR through jitpack.
This allows us to specify what cbioportal-frontend url should be used. It overrides whatever frontend version is provided in the WAR through jitpack.
- frontend.url allows us to specify what cbioportal-frontend url should be used. It overrides whatever frontend version is provided in the WAR through jitpack. - frontend.url.runtime allows us to specify a file that contains the runtime version (eventually this should also support a URL)
- frontend.url allows us to specify what cbioportal-frontend url should be used. It overrides whatever frontend version is provided in the WAR through jitpack. - frontend.url.runtime allows us to specify a file that contains the runtime version (eventually this should also support a URL)
- frontend.url: specify what cbioportal-frontend url should be used. It overrides whatever frontend version is provided in the WAR through jitpack. - frontend.url.runtime: specify a file that contains the runtime version (eventually this should also support a URL). Overrides frontend.url. - Add FRONTEND_URL env variable to Heroku
- frontend.url: specify what cbioportal-frontend url should be used. It overrides whatever frontend version is provided in the WAR through jitpack. - frontend.url.runtime: specify a file that contains the runtime version (eventually this should also support a URL). Overrides frontend.url. - Add FRONTEND_URL env variable to Heroku
Fix #2778 frontend.url, frontend.url.runtime props
Currently we can only change frontend version by changing
portal/pom.xml
. We should change this to an environment variable/property so on heroku we can for instance just change the env variable of the instance instead of having to make changes to thecbioportal
repo'spom
file. The latter will then only have to be done at the final stage when we deploy officially.The text was updated successfully, but these errors were encountered: