Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use property/env variable to specify frontend version #2778

Closed
inodb opened this issue Jul 19, 2017 · 4 comments
Closed

Use property/env variable to specify frontend version #2778

inodb opened this issue Jul 19, 2017 · 4 comments

Comments

@inodb
Copy link
Member

inodb commented Jul 19, 2017

Currently we can only change frontend version by changing portal/pom.xml. We should change this to an environment variable/property so on heroku we can for instance just change the env variable of the instance instead of having to make changes to the cbioportal repo's pom file. The latter will then only have to be done at the final stage when we deploy officially.

@inodb inodb added the frontend label Jul 19, 2017
@inodb inodb self-assigned this Jul 19, 2017
@jjgao
Copy link
Member

jjgao commented Jul 19, 2017

@inodb I have mixed feelings about this. On one hand, it's a good idea to free frontend from backend. On the other hand, the frontend is still tightly connected to the current portal and core modules. Only specific versions of portal-frontend and portal can work together. For the moment, I think it may be still better to check in the frontend version into a file (not necessary pom.xml though).

Once we discard the portal and core modules and the API is more stable, we can decouple the frontend. We still need to find a way to specify which API version is working for which frontend version.

@inodb
Copy link
Member Author

inodb commented Jul 19, 2017

@jjgao I think it would be very useful for review on Heroku at the moment. Currently we do the same thing during development using our localDev=true trick, but it's more tricky to share a URL, since you have to make changes to the pom file on the backend. It would for the start just be for internal development use.

If we are going to expand the use of this feature to other portal maintainers I agree that it would be better to first have better warning messages when the frontend & api mismatch.

@jjgao
Copy link
Member

jjgao commented Jul 19, 2017

@inodb maybe in addition to the checked in version, we can support it in props file (which overrides the checked-in one)? We don't have to document it in order to keep it just for dev purposes for now.

@inodb
Copy link
Member Author

inodb commented Jul 19, 2017

@jjgao yes, exactly

inodb added a commit to inodb/cbioportal that referenced this issue Aug 11, 2017
This allows us to specify what cbioportal-frontend url should be used. It
overrides whatever frontend version is provided in the WAR through jitpack.
inodb added a commit to inodb/cbioportal that referenced this issue Aug 14, 2017
This allows us to specify what cbioportal-frontend url should be used. It
overrides whatever frontend version is provided in the WAR through jitpack.
inodb added a commit to inodb/cbioportal that referenced this issue Aug 16, 2017
- frontend.url allows us to specify what cbioportal-frontend url
should be used. It overrides whatever frontend version is provided in the WAR
through jitpack.
- frontend.url.runtime allows us to specify a file that contains the runtime
  version (eventually this should also support a URL)
inodb added a commit to inodb/cbioportal that referenced this issue Aug 16, 2017
- frontend.url allows us to specify what cbioportal-frontend url
should be used. It overrides whatever frontend version is provided in the WAR
through jitpack.
- frontend.url.runtime allows us to specify a file that contains the runtime
  version (eventually this should also support a URL)
@inodb inodb reopened this Aug 16, 2017
inodb added a commit to inodb/cbioportal that referenced this issue Aug 16, 2017
- frontend.url: specify what cbioportal-frontend url should be used. It
  overrides whatever frontend version is provided in the WAR through jitpack.
- frontend.url.runtime: specify a file that contains the runtime version
  (eventually this should also support a URL). Overrides frontend.url.
-  Add FRONTEND_URL env variable to Heroku
inodb added a commit to inodb/cbioportal that referenced this issue Aug 17, 2017
- frontend.url: specify what cbioportal-frontend url should be used. It
  overrides whatever frontend version is provided in the WAR through jitpack.
- frontend.url.runtime: specify a file that contains the runtime version
  (eventually this should also support a URL). Overrides frontend.url.
-  Add FRONTEND_URL env variable to Heroku
@inodb inodb reopened this Aug 17, 2017
alisman added a commit that referenced this issue Aug 17, 2017
Fix #2778 frontend.url, frontend.url.runtime props
@inodb inodb closed this as completed Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants