Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the broken download button in clinical data tab in study view #5062

Closed
wants to merge 3 commits into from

Conversation

MalavikaS2000
Copy link

Resolves #11142

  • Fixed the button to get file in tsv format instead of json format.
  • Added validations to handle empty arrays.
  • Verified that the download button works as expected and generates the right file format.
  • Ran all tests to assure nothing else was accidentally broken in the java part by running: mvn integration-test.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit a9f03b4
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/675fbeb0a356710008518fa8
😎 Deploy Preview https://deploy-preview-5062.cancerrevue.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisman alisman requested a review from gblaih December 16, 2024 15:19
@alisman
Copy link
Collaborator

alisman commented Dec 16, 2024

@gblaih can you review and test this PR? thanks! (@MalavikaS2000 thanks for submitting)

@gblaih
Copy link
Contributor

gblaih commented Dec 27, 2024

closing this, already fixed by #5058

@gblaih gblaih closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants