Custom data Enhancements for Plots Tab #4994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Nelliney
force-pushed
the
custom-data
branch
from
458aa5c to
2b44bbe
Compare
Nelliney
force-pushed
the
custom-data
branch
from
7dd4281 to
6450eae
Compare
dippindots
reviewed
Sep 12, 2024
There was a problem hiding this comment.
@Nelliney Overall it looks good to me, great pull request. I just have a few minor comments here.
gblaih
reviewed
Sep 12, 2024
gblaih
reviewed
Sep 12, 2024
Nelliney
force-pushed
the
custom-data
branch
from
0836d7a to
2caca53
Compare
gblaih
reviewed
Sep 13, 2024
Nelliney
force-pushed
the
custom-data
branch
from
ca9df28 to
3dc8ee3
Compare
gblaih
approved these changes
Sep 19, 2024
alisman
reviewed
Sep 23, 2024
| studyIds: this.studyIds.result!, | ||
| } | ||
| ); | ||
| const specialAttributes = [ |
There was a problem hiding this comment.
i think these are just special attributes that were already in clinicalAttributes from the store. so this plotClinicalAttributes is just clinicalAttributes without the custom attributes.
There was a problem hiding this comment.
Yes, it is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a custom attribute type to the combo box and implemented changes to ensure custom data is visible on the graph. Additionally, enabled the option to color by custom data. Note: Custom data can be added when logged in (this was the initial behavior for custom data).
fix cBioPortal/cbioportal#10970 (comment)