move sync to async for all remote tests #4920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
for some reason this test does not pass |
|
|
|
|
|
bemijonathan
force-pushed
the
feature/bemijonathan-move-sync-to-async
branch
from
6b45d7e to
c0c1bce
Compare
|
bemijonathan
force-pushed
the
feature/bemijonathan-move-sync-to-async
branch
from
5c793b3 to
bd9721e
Compare
alisman
reviewed
Jun 25, 2024
| 'Another group already has this name.' | ||
| ); | ||
| assert.equal( | ||
| $('[data-test="sampleGroupNameSubmitButton"]').isEnabled(), | ||
| await ( |
There was a problem hiding this comment.
i wish there was some way we could chain this but i think there isn't any way. (i mean the await await thing)
bemijonathan
force-pushed
the
feature/bemijonathan-move-sync-to-async
branch
from
7275e17 to
1adafee
Compare
alisman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move test cases from sync to async on remote/customTab.spec.js