add search filter criteria for authorized and unauthorized studies #4825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisman
reviewed
Apr 15, 2024
| @@ -1511,6 +1511,16 @@ export class QueryStore { | |||
| return new Set(referenceGenomes); | |||
| } | |||
|
|
|||
| @computed get readPermissions(): Set<string> { | |||
| const studies = Array.from(this.treeData.map_node_meta.keys()).filter( | |||
| s => typeof (s as CancerStudy).readPermission !== 'undefined' | |||
There was a problem hiding this comment.
(s:CancerStudy)=>s.readPermission===undefined
should work. You don't need typeof anymore. Possible that you will need to cast with as, but not sure.
alisman
reviewed
Apr 15, 2024
| s => typeof (s as CancerStudy).readPermission !== 'undefined' | ||
| ); | ||
| const readPermissions = studies.map(n => | ||
| (n as CancerStudy).readPermission.toString() |
There was a problem hiding this comment.
(n:CancerStudy)=>readPermission (probably already a string?)
alisman
reviewed
Apr 15, 2024
| @@ -129,7 +129,7 @@ export class ListPhrase implements Phrase { | |||
| for (const fieldName of this.fields) { | |||
| let anyPhraseMatch = false; | |||
| const fieldValue = study[fieldName]; | |||
| if (fieldValue) { | |||
| if (typeof fieldValue !== 'undefined') { | |||
alisman
reviewed
Apr 15, 2024
| function matchPhraseFull(phrase: string, fullText: string) { | ||
| return fullText.toLowerCase() === phrase.toLowerCase(); | ||
| function matchPhraseFull(phrase: string, toMatch: boolean | string | number) { | ||
| return _.toString(toMatch).toLowerCase() === phrase.toLowerCase(); |
There was a problem hiding this comment.
probably don'tneed to use _ (lodash here). just toMatch.toString().toLowerCase()
alisman
reviewed
Apr 15, 2024
| {} | ||
| > { | ||
| constructor(props: { ids: String[] }) { | ||
| super(props); | ||
| this.state = { |
There was a problem hiding this comment.
we try to use mobx state instead of react state. for consistency. just put it as an observable property on the component
alisman
reviewed
Apr 15, 2024
|
|
||
| <div | ||
| style={{ | ||
| width: '100%', |
There was a problem hiding this comment.
probably don't need width:100%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/icebox#468
add search filter criteria for authorized and unauthorized studies
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>to determine thatand notify them either through slack or by assigning them as a reviewer on the PR