-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(GSoC) Generic Assay Categorical/Binary data implementation Frontend #4686
(GSoC) Generic Assay Categorical/Binary data implementation Frontend #4686
Conversation
packages/genome-nexus-ts-api-client/src/generated/GenomeNexusAPI-docs.json
Outdated
Show resolved
Hide resolved
src/pages/groupComparison/GenericAssayEnrichmentCollections.tsx
Outdated
Show resolved
Hide resolved
e7ee918
to
364812a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Djokovic0311 It's looking good to me, just have a few minor feedback. It's also good to see if we can update these comments from the product team:
- Consistent naming for y-axis labels (change
altered frequency
->frequency
) - In category tab always show first plot (first row selected by default)
We might want to add feature flag
for our feature too, this feature flag will check for url parameters if we want to show a specific feature. It's a way we can merge pr first and then let the product team test the feature in an easy way.
See the example here: https://github.com/cBioPortal/cbioportal-frontend/blob/master/src/pages/groupComparison/GroupComparisonStore.ts#L667-L669
- Add feature flag for
genericAssayBinaryTabShowable
andgenericAssayCategoricalTabShowable
src/pages/groupComparison/GenericAssayEnrichmentCollections.tsx
Outdated
Show resolved
Hide resolved
b080149
to
893c710
Compare
893c710
to
ca43da7
Compare
@Djokovic0311 Congrats! I just merged the fronted part of the project. Although it's still behind the feature flag, now the product team can test this easily. I will remove the feature flag after the product team says it's ok to release. Thanks for your hard work this summer!! |
@dippindots Thank you again for your guidance! Grateful for the opportunity to work on this during GSoC and for having you as a mentor. Looking forward to more collaborations in the future! |
Summary
Changes proposed in this pull request:
Add tabs to display three types of Generic Assay Data profiles grouped by their generic assay data type, applying a drop down list to select each profile to render in the tab.
Implement Generic Assay Categorical Data Display as below:
The content is the same as above.
Could you please have a look at this pr? @dippindots @fuzhaoyuan Any suggestions or modifications are welcome!