Download data from study view treatment tables #4595
Conversation
|
Thanks @Player256! The downloaded data seems similar for Full and Summary Data. For e.g. this study: https://deploy-preview-4595--cbioportalfrontend.netlify.app/study/summary?id=lgg_ucsf_2014 It also has new lines instead of being tab separated, could you help fix that? Thanks so much! |
There was a problem hiding this comment.
@Player256 Thank you so much for trying to fix this issue, I put some comments here, please feel free to ask me any questions regarding them.
| @@ -649,6 +649,9 @@ export class StudySummaryTab extends React.Component< | |||
| props.filters = this.store.patientTreatmentFiltersAsStrings; | |||
| props.promise = this.store.patientTreatments; | |||
| props.onValueSelection = this.store.onTreatmentSelection; | |||
| props.getData = () => | |||
| this.store.getPatientTreatmentDownloadData(); | |||
| props.downloadTypes = ['Full Data', 'Summary Data']; | |||
There was a problem hiding this comment.
What's the difference between these two? Maybe we can just offer one available download type Data?
There was a problem hiding this comment.
Oh you are right @dippindots. I looked through the pie chart data
There was a problem hiding this comment.
@Player256 Thanks for addressing all my comments, this looks good to me now!
|
Thank you @dippindots. |
|
@inodb This pull request looks good to me, I will merge this one. If there is anything you want to add as an follow-up task, please feel free to create another ticket! Thanks. |
Fixes cBioPortal/cbioportal #10122
Describe changes proposed in this pull request:
Link: https://genie.cbioportal.org/study/summary?id=nsclc_public_genie_bpc