Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Add Configurable Param for max number of samples in study vi… #4587

Conversation

haynescd
Copy link
Contributor

Fix cBioPortal/cbioportal#10125

Describe changes proposed in this pull request:
Add studyview.max_samples_selected property to make Study View limit configurable. Default is set to 100,000

@haynescd haynescd requested a review from alisman April 18, 2023 18:53
@haynescd haynescd self-assigned this Apr 18, 2023
@haynescd haynescd marked this pull request as ready for review April 18, 2023 18:55
@haynescd haynescd requested a review from pvannierop April 19, 2023 14:45
@haynescd haynescd force-pushed the feature/10125-Add-Config-Properties-For-max-studies-selected branch 3 times, most recently from ab373b8 to f7ccaad Compare April 20, 2023 18:06
@haynescd haynescd force-pushed the feature/10125-Add-Config-Properties-For-max-studies-selected branch from f7ccaad to b0a9164 Compare April 21, 2023 18:30
@alisman
Copy link
Collaborator

alisman commented Apr 24, 2023

@haynescd i think we decided that we would not impose the limit when only ONE study was selected.

@haynescd haynescd force-pushed the feature/10125-Add-Config-Properties-For-max-studies-selected branch from b0a9164 to 88c0c8d Compare April 25, 2023 15:37
@alisman alisman merged commit 88899c2 into cBioPortal:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a configuration property to control max number of studies in study view page
2 participants