Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak style of oncoprint controls #4548

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

aditygrg2
Copy link
Contributor

@aditygrg2 aditygrg2 commented Mar 16, 2023

Fix cBioPortal/cbioportal#10086

Describe changes proposed in this pull request:
Updated the centering of the +, and - buttons in the oncoprinter config button, which earlier was not looking good. This was due to the border width as it was not subtracted from the initial positioning of the pseudo icon.

Before:
Screenshot 2023-03-16 at 16 49 19

After:
Screenshot 2023-03-16 at 17 11 37

@aditygrg2
Copy link
Contributor Author

@inodb @alisman Please review, I would like your suggestions on this and work upon them to improve this PR

@alisman alisman changed the title Oncoprint controls Tweak style of oncoprint controls Apr 20, 2023
@alisman alisman merged commit d8699dd into cBioPortal:master Apr 20, 2023
@alisman alisman added the style tweak To indicate the PR does a minor style tweak label Apr 20, 2023
@alisman
Copy link
Collaborator

alisman commented Apr 20, 2023

thank you @aditygrg2 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style tweak To indicate the PR does a minor style tweak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase and decrease icon button on oncoprint page
2 participants