Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier #3002

Merged
merged 18 commits into from
Jan 27, 2020
Merged

Prettier #3002

merged 18 commits into from
Jan 27, 2020

Conversation

adamabeshouse
Copy link
Contributor

No description provided.

@adamabeshouse adamabeshouse force-pushed the prettier branch 13 times, most recently from 459185d to 050a6bd Compare January 24, 2020 21:10
package.json Outdated
@@ -47,7 +50,9 @@
"testModules": "lerna run test --ignore=cbioportal-frontend --stream",
"test:watch": "yarn run test -- --watch",
"test:debug": "yarn run test -- --debug --browsers=Chrome_with_debugging --single-run=false",
"prettierLastCommit": "yarn run prettier --write $(git diff-tree --no-commit-id --name-only -r $(git rev-parse HEAD))",
"prettierFixCurrentChanges": "yarn run prettier --write $(git diff HEAD --name-only)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - it does also seem to ignore things in prettierignore even if you explicitly pass that file to prettier. Sweet

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ✨

pretty

@alisman alisman requested a review from Luke-Sikina January 27, 2020 18:54
Copy link
Member

@Luke-Sikina Luke-Sikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but make sure to update the Formatting Code with Prettier JS section of the README

Abeshouse, Adam A./Sloan Kettering Institute added 11 commits January 27, 2020 15:11
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
…prettierFix command

Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Abeshouse, Adam A./Sloan Kettering Institute added 5 commits January 27, 2020 16:10
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
@adamabeshouse adamabeshouse merged commit 5345fa2 into cBioPortal:master Jan 27, 2020
@adamabeshouse adamabeshouse deleted the prettier branch January 27, 2020 23:32
@inodb inodb added chore This PR is related to code maintenance and removed DO NOT MERGE labels Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This PR is related to code maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants