MatchMiner increase column width for clinical criteria #2978
Conversation
…hed based on clinical infos only
|
@victoria34 this looks fine to me. we should try to get in the habit of asking product owners (Sarah? Debiani?) to review this in the browser before we merge. They can do this by making the following bookmark in their browser: javascript: Then, go the page where they want to see the new UI on the live site and click the button. They will be prompted for a PR number. In this case, 2978. The page will reload and they should then see the changes you made in the context of the production website. Note that this works only for frontend changes. |
Thanks for letting me know. This is really helpful to me and Sarah @phillis2. Hi Sarah @phillis2, could you try this when you get a chance. If you have feedback, please leave your comments in here. Thanks |
|
Hi @alisman, could you review my PR when you get a chance? Thanks |
| @@ -69,10 +69,10 @@ export function groupTrialMatchesByAgeNumerical(armGroup: ITrialMatch[]): IClini | |||
| } | |||
| }; | |||
| const positiveTrialMatches = _.filter(matchesGroupedByAge[age], (trialMatch:ITrialMatch) => { | |||
| if (!_.isUndefined(trialMatch.genomicAlteration)) return !trialMatch.genomicAlteration.includes('!') | |||
| if (!_.isUndefined(trialMatch.genomicAlteration) && trialMatch.genomicAlteration !== '') return !trialMatch.genomicAlteration.includes('!') | |||
There was a problem hiding this comment.
always use brackets after if statements:
| if (!_.isUndefined(trialMatch.genomicAlteration) && trialMatch.genomicAlteration !== '') return !trialMatch.genomicAlteration.includes('!') | |
| if (!_.isUndefined(trialMatch.genomicAlteration) && trialMatch.genomicAlteration !== '') { | |
| return !trialMatch.genomicAlteration.includes('!') | |
| } |
There was a problem hiding this comment.
Will update my code. Thanks
| }); | ||
| const negativeTrialMatches = _.filter(matchesGroupedByAge[age], (trialMatch:ITrialMatch) => { | ||
| if (!_.isUndefined(trialMatch.genomicAlteration)) return trialMatch.genomicAlteration.includes('!') | ||
| if (!_.isUndefined(trialMatch.genomicAlteration) && trialMatch.genomicAlteration !== '') return trialMatch.genomicAlteration.includes('!') |
There was a problem hiding this comment.
same as above, always use brackets
| @@ -64,7 +64,7 @@ | |||
| .firstRight{ | |||
| display:flex; | |||
| flex: 0 0 auto; | |||
| width: 300px; | |||
| width: 50%; | |||
There was a problem hiding this comment.
the PR title says 100%, but we set it here to 50%. Are they two unrelated things?
There was a problem hiding this comment.
The default width is 50% but it will be set as 100% when there is no genomic content.
inodb
added
cl-style-tweak
inodb
changed the title
Fix oncokb/oncokb#1891
Most trials are matched based on both clinical and genomic criteria. However, some of them can be matched only by clinical criteria. I changed the width to 100% instead of 50% for that case.