Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oncoprint - fix occasional bug with removing tracks #2930

Merged
merged 2 commits into from
Jan 21, 2020
Merged

oncoprint - fix occasional bug with removing tracks #2930

merged 2 commits into from
Jan 21, 2020

Conversation

adamabeshouse
Copy link
Contributor

@adamabeshouse adamabeshouse commented Dec 11, 2019 •
edited by jjgao
Loading

@jjgao jjgao temporarily deployed to cbioportal-f-tx-bug-wgzixlpfzu December 11, 2019 22:31 Inactive
@alisman
Copy link
Collaborator

alisman commented Dec 16, 2019 •
edited
Loading

@adamabeshouse. Now I get error when I remove the last treatment track:

https://deploy-preview-2930--cbioportalfrontend.netlify.com/results/oncoprint?Action=Submit&RPPA_SCORE_THRESHOLD=2.0&Z_SCORE_THRESHOLD=2.0&cancer_study_list=ccle_broad_2019&case_set_id=ccle_broad_2019_cnaseq&data_priority=0&gene_list=CDKN2A%2520MDM2%2520MDM4%2520TP53&geneset_list=%20&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=ccle_broad_2019_cna&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=ccle_broad_2019_mutations&heatmap_track_groups=ccle_broad_2019_CCLE_drug_treatment_IC50%2CAfatinib-1%2CAfatinib-2%2CAKTinhibitorVIII-1&profileFilter=0&tab_index=tab_visualize&treatment_list=Afatinib-1%3BAfatinib-2%3BAKTinhibitorVIII-1

@jjgao jjgao had a problem deploying to cbioportal-f-tx-bug-pdxtvcpsqj January 3, 2020 22:57 Failure
@jjgao jjgao had a problem deploying to cbioportal-f-tx-bug-pdxtvcpsqj January 7, 2020 21:31 Failure
@jjgao jjgao had a problem deploying to cbioportal-f-tx-bug-pdxtvcpsqj January 7, 2020 23:27 Failure
@jjgao jjgao had a problem deploying to cbioportal-f-tx-bug-pdxtvcpsqj January 8, 2020 21:17 Failure
@jjgao jjgao had a problem deploying to cbioportal-f-tx-bug-pdxtvcpsqj January 8, 2020 23:19 Failure
@jjgao jjgao had a problem deploying to cbioportal-f-tx-bug-pdxtvcpsqj January 14, 2020 17:12 Failure
@jjgao jjgao had a problem deploying to cbioportal-f-tx-bug-pdxtvcpsqj January 14, 2020 18:42 Failure
@jjgao jjgao had a problem deploying to cbioportal-f-tx-bug-pdxtvcpsqj January 14, 2020 23:32 Failure
@jjgao jjgao had a problem deploying to cbioportal-f-tx-bug-pdxtvcpsqj January 17, 2020 21:12 Failure
@jjgao jjgao temporarily deployed to cbioportal-f-tx-bug-pdxtvcpsqj January 17, 2020 22:27 Inactive
Abeshouse, Adam A./Sloan Kettering Institute added 2 commits January 21, 2020 12:02
oncoprint - fix bugs with removing tracks arising from putting more o…
a9f1811 
…ncoprint state in URL

Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
Take out unused parameter in URL which will cause unnecessary page re…
04b782e 
…rendering and thus flakey e2es

Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
@adamabeshouse adamabeshouse merged commit 164b676 into cBioPortal:master Jan 21, 2020
@adamabeshouse adamabeshouse deleted the tx-bug branch January 21, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisman alisman alisman approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing first treatment from heatmap tracks causes oncoprint error
3 participants
@adamabeshouse @alisman @jjgao