fix pvge mutation table count header and adjust badge selector height

cBioPortal · Mar 23, 2023 · efc68e9 · efc68e9
1 parent f9b8f3b
commit efc68e9
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/src/pages/groupComparison/GroupComparisonMutationMapper.tsx b/src/pages/groupComparison/GroupComparisonMutationMapper.tsx
@@ -148,6 +148,7 @@ export default class GroupComparisonMutationMapper extends MutationMapper<
                 profiledPatientCountsByGroup={this.profiledPatientCountsByGroup}
                 groups={this.props.groups}
                 formatPaginationStatusText={this.formatPaginationStatusText}
+                showTotalMutationCountsInCountHeader={true}
             />
         );
     }
@@ -206,7 +207,7 @@ export default class GroupComparisonMutationMapper extends MutationMapper<
                         groupNameWithOrdinal={
                             this.props.groups[groupIndex].nameWithOrdinal
                         }
-                        height={149}
+                        height={148}
                     />
                 ) : (
                     <ProteinImpactTypeBadgeSelector
@@ -222,7 +223,7 @@ export default class GroupComparisonMutationMapper extends MutationMapper<
                         groupNameWithOrdinal={
                             this.props.groups[groupIndex].nameWithOrdinal
                         }
-                        height={109}
+                        height={108}
                     />
                 )}
             </>

diff --git a/src/shared/components/lazyMobXTable/LazyMobXTable.tsx b/src/shared/components/lazyMobXTable/LazyMobXTable.tsx
@@ -121,6 +121,7 @@ type LazyMobXTableProps<T> = {
     ) => JSX.Element | undefined;
     deactivateColumnFilter?: (columnId: string) => void;
     formatPaginationStatusText?: (text: string) => string;
+    showTotalMutationCountsInCountHeader?: boolean;
 };
 
 function compareValues<U extends number | string>(
@@ -1116,7 +1117,9 @@ export default class LazyMobXTable<T> extends React.Component<
                     fontWeight: 'bold',
                 }}
             >
-                {_.flatten(this.store.displayData).length}{' '}
+                {this.props.showTotalMutationCountsInCountHeader
+                    ? _.flatten(this.store.displayData).length
+                    : this.store.displayData.length}{' '}
                 {this.store.itemsLabel} (page {this.store.page + 1} of{' '}
                 {this.store.maxPage + 1})
             </span>

diff --git a/src/shared/components/mutationTable/MutationTable.tsx b/src/shared/components/mutationTable/MutationTable.tsx
@@ -160,6 +160,7 @@ export interface IMutationTableProps {
     };
     groups?: ComparisonGroup[];
     formatPaginationStatusText?: (text: string) => string;
+    showTotalMutationCountsInCountHeader?: boolean;
 }
 import MobxPromise from 'mobxpromise';
 import { getServerConfig } from 'config/config';
@@ -1432,6 +1433,9 @@ export default class MutationTable<
                 formatPaginationStatusText={
                     this.props.formatPaginationStatusText
                 }
+                showTotalMutationCountsInCountHeader={
+                    this.props.showTotalMutationCountsInCountHeader
+                }
             />
         );
     }