Merge pull request #4719 from jfkonecn/hotfix

search returns false for bad regex
cBioPortal · Sep 12, 2023 · 7d889f6 · 7d889f6
2 parents b96e11e + 6cfd9ae
commit 7d889f6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/.gitignore b/.gitignore
@@ -63,3 +63,5 @@ cert.pem
 end
 e2e-localdb-workspace/
 junit.xml
+.nvim.lua
+.luarc.json
diff --git a/src/shared/lib/GenericAssayUtils/GenericAssaySelectionUtils.ts b/src/shared/lib/GenericAssayUtils/GenericAssaySelectionUtils.ts
@@ -4,13 +4,17 @@ export interface ISelectOption {
 }
 
 export function doesOptionMatchSearchText(text: string, option: ISelectOption) {
-    let result = false;
-    if (
-        !text ||
-        RegExp(text, 'i').test(option.label) ||
-        RegExp(text, 'i').test(option.value)
-    ) {
-        result = true;
+    try {
+        let result = false;
+        if (
+            !text ||
+            RegExp(text, 'i').test(option.label) ||
+            RegExp(text, 'i').test(option.value)
+        ) {
+            result = true;
+        }
+        return result;
+    } catch {
+        return false;
     }
-    return result;
 }