Merge pull request Expensify#48445 from bernhardoj/fix/47735-unread-l…

…ine-shows-on-a-new-msg Fix unread indicator isn't cleared when deleting the unread message
c3024 · Sep 3, 2024 · 2d1f8cd · 2d1f8cd
2 parents 5db0996 + 2d880ca
commit 2d1f8cd
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/pages/home/report/ReportActionsList.tsx b/src/pages/home/report/ReportActionsList.tsx
@@ -278,7 +278,7 @@ function ReportActionsList({
         }
 
         const mostRecentReportActionCreated = sortedVisibleReportActions[0]?.created ?? '';
-        if (mostRecentReportActionCreated <= unreadMarkerTime) {
+        if (mostRecentReportActionCreated === unreadMarkerTime) {
             return;
         }
 

diff --git a/tests/perf-test/ReportActionsList.perf-test.tsx b/tests/perf-test/ReportActionsList.perf-test.tsx
@@ -82,23 +82,31 @@ beforeEach(() => {
 });
 
 function ReportActionsListWrapper() {
+    const reportActions = ReportTestUtils.getMockedSortedReportActions(500);
+    const lastVisibleActionCreated = reportActions[0].created;
+    const report = {
+        ...LHNTestUtilsModule.getFakeReport(),
+        lastVisibleActionCreated,
+        lastReadTime: lastVisibleActionCreated,
+    };
+
     return (
         <ComposeProviders components={[OnyxProvider, LocaleContextProvider, WindowDimensionsProvider, ReportAttachmentsProvider]}>
             <ReactionListContext.Provider value={mockRef}>
                 <ActionListContext.Provider value={mockRef}>
                     <ReportActionsList
                         parentReportAction={createRandomReportAction(1)}
                         parentReportActionForTransactionThread={undefined}
-                        sortedReportActions={ReportTestUtils.getMockedSortedReportActions(500)}
-                        report={LHNTestUtilsModule.getFakeReport()}
+                        sortedReportActions={reportActions}
+                        report={report}
                         onLayout={mockOnLayout}
                         onScroll={mockOnScroll}
                         onContentSizeChange={() => {}}
                         listID={1}
                         loadOlderChats={mockLoadChats}
                         loadNewerChats={mockLoadChats}
                         transactionThreadReport={LHNTestUtilsModule.getFakeReport()}
-                        reportActions={ReportTestUtils.getMockedSortedReportActions(500)}
+                        reportActions={reportActions}
                     />
                 </ActionListContext.Provider>
             </ReactionListContext.Provider>
-Original file line number
+Diff line change
@@ Expand Up / @@ -278,7 +278,7 @@ function ReportActionsList({ @@
             }
             const mostRecentReportActionCreated = sortedVisibleReportActions[0]?.created ?? '';
-            if (mostRecentReportActionCreated <= unreadMarkerTime) {
+            if (mostRecentReportActionCreated === unreadMarkerTime) {
                 return;
             }
@@ Expand Down @@