Skip to content

Commit

Permalink
docs: bump umamba version docs
Browse files Browse the repository at this point in the history
  • Loading branch information
luciorq committed Oct 30, 2024
1 parent 0b4f562 commit 80a09c4
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
5 changes: 4 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@

## New features

* `install_micromamba()` now tries to download an uncompressed version of the micromamba binary if `untar()` fails
because of missing `bzip2` system library. (#10 and #14)

## Minor improvements and fixes

* Internal `micromamba` version bump to "2.0.2-1".
* Internal `micromamba` version bump to "2.0.2-2".

# condathis 0.0.6

Expand Down
2 changes: 1 addition & 1 deletion R/create_env.R
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ create_env <- function(
method <- rlang::arg_match(method)

env_file_path <- NULL
if (!is.null(env_file)) {
if (isFALSE(is.null(env_file))) {
if (fs::file_exists(env_file)) {
env_file_path <- fs::path(env_file)
packages_arg <- c("-f", env_file_path)
Expand Down
5 changes: 2 additions & 3 deletions R/install_micromamba.R
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#' to create and manage conda environments.
#'
#' @param micromamba_version Character string specifying the version of Micromamba to download.
#' Defaults to `"2.0.2-1"`.
#' Defaults to `"2.0.2-2"`.
#'
#' @param timeout_limit Numeric value specifying the timeout limit for downloading the Micromamba
#' binaries, in seconds. Defaults to `3600` seconds (1 hour).
Expand Down Expand Up @@ -106,7 +106,6 @@ install_micromamba <- function(micromamba_version = "2.0.2-2",
fs::file_delete(full_dl_path)
}

# NOTE: @luciorq Attempt to solver #10 and #14
if (isFALSE(nzchar(Sys.which("bzip2")) && fs::file_exists(umamba_bin_path))) {
download_url <- paste0(
base_url, "download/", micromamba_version, "/micromamba-", sys_arch_str
Expand Down Expand Up @@ -139,7 +138,7 @@ install_micromamba <- function(micromamba_version = "2.0.2-2",
cli::cli_abort(
message = c(
`x` = "{.file {umamba_bin_path}} was not extracted succesfully.",
`!` = "This error can be caused by missing `bzip2` system library."
`!` = "This error may be caused by missing `bzip2` system library."
),
class = "condathis_install_error_missing_bzip2"
)
Expand Down
2 changes: 1 addition & 1 deletion man/install_micromamba.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 80a09c4

Please sign in to comment.