Add support for Japanese subject #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlechaMaker
commented
Jul 2, 2023
FlechaMaker
commented
- Add Japanese subject format
- Fix citation alert normalization to support the subject with number of citation
- Add test case for Japanese alert (My Google account receives ".com.au" links in Japanese alert, so I also added ".com.au" to the test case.)
bzz
reviewed
Sep 9, 2023
| } | ||
| citations = subjFormat{ | ||
| ": новые ссылки", "new citations", | ||
| ": новые ссылки", `^(?:(.+) さん|(自分))の論文からの引用: \d+ 件$`, `^\d+ new citations? to articles by (.+)$`, |
There was a problem hiding this comment.
I wonder if the first one also needs to be updated with a regex for a number - I'll check that before merging.
There was a problem hiding this comment.
Thank you for the check! I don't have knowledge and testing environment for the language, so the update will be fine.
|
Thank you so much for sharing the improvements! 🙇 Overall it looks great, but if you don't mind - I'm going to add the CI first so we could use this to test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.