Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove custom have_attributes matcher
This removes our custom have_attributes matcher which overrides RSpec's default one. Ours added some functionality that doesn't need to exist and can be done with other matchers like `include`. Basically: * Use `expect(thing).to include()` for collections, like hashes (most common offense we use this custom one for). https://relishapp.com/rspec/rspec-expectations/v/3-7/docs/built-in-matchers/include-matcher * Use `expect(thing).to have_attributes()` for other objects that actually have methods for the things you're checking. Models, for example. https://relishapp.com/rspec/rspec-expectations/docs/built-in-matchers/have-attributes-matcher
- Loading branch information