Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithElements to Section #959

Merged
merged 3 commits into from
Mar 4, 2022

Conversation

rxt1077
Copy link
Contributor

@rxt1077 rxt1077 commented Mar 3, 2022

Resolves #958
This PR allows WithElements to be used in the Section type.

@rxt1077 rxt1077 changed the title Add WithElements to Section resolves #958 Add WithElements to Section Mar 3, 2022
pkg/types/types.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #959 (7fc8f3b) into master (8e3016b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
+ Coverage   79.58%   79.59%   +0.01%     
==========================================
  Files          85       85              
  Lines        6828     6833       +5     
==========================================
+ Hits         5434     5439       +5     
  Misses        885      885              
  Partials      509      509              

@rxt1077 rxt1077 closed this Mar 3, 2022
@rxt1077 rxt1077 force-pushed the Section-WithElements branch from ae7ec7e to ada72a8 Compare March 3, 2022 21:25
@rxt1077 rxt1077 reopened this Mar 3, 2022
@xcoulon xcoulon merged commit 6ddd7e6 into bytesparadise:master Mar 4, 2022
@rxt1077 rxt1077 deleted the Section-WithElements branch March 4, 2022 14:53
@xcoulon
Copy link
Member

xcoulon commented Mar 4, 2022

thanks @rxt1077 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WithElements interface to Section
2 participants