Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(renderer): inline images deserve links, too #754

Merged
merged 1 commit into from
Sep 13, 2020
Merged

feature(renderer): inline images deserve links, too #754

merged 1 commit into from
Sep 13, 2020

Conversation

pjanx
Copy link
Contributor

@pjanx pjanx commented Sep 13, 2020

They are used in libasciidoc's own README.adoc for badges and I wanted to use them in mine, without working around it with line noise:

perl -pe 's|\b(image:.*?\[.*?),\s*link=([^,]*?)(\])|+++<a href=$2>+++\n$1$3\n+++</a>+++|gx'

So that I'm not just bitching in issues. :) This was easy enough to add, even if tiring because of two super similar backends. Also notice that the templates are formatted differently.

They are used in libasciidoc's own README.adoc.
@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #754 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #754   +/-   ##
=======================================
  Coverage   83.52%   83.52%           
=======================================
  Files          77       77           
  Lines        5602     5603    +1     
=======================================
+ Hits         4679     4680    +1     
  Misses        586      586           
  Partials      337      337           

@gdamore
Copy link
Collaborator

gdamore commented Sep 13, 2020

Looks pretty good to me... sorry for missing this in the original work.

@xcoulon
Copy link
Member

xcoulon commented Sep 13, 2020

thanks for addressing this issue, @pjanx 🙌

@xcoulon xcoulon merged commit 3480071 into bytesparadise:master Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants