fix(renderer): do not 'HTML escape' string elements #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With support for special characters in place, there is no need to using the HTML "escape" func when rendering StringElements. Fixes bytesparadise#741 Signed-off-by: Xavier Coulon <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
- Coverage 83.53% 83.52% -0.01%
==========================================
Files 77 77
Lines 5605 5602 -3
==========================================
- Hits 4682 4679 -3
Misses 586 586
Partials 337 337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With support for special characters in place, there is
no need to using the HTML "escape" func when
rendering StringElements.
Fixes #741
Signed-off-by: Xavier Coulon [email protected]