refactor(parser/renderer): special characters at parser level #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
==========================================
- Coverage 85.00% 84.97% -0.03%
==========================================
Files 75 76 +1
Lines 5194 5213 +19
==========================================
+ Hits 4415 4430 +15
- Misses 492 494 +2
- Partials 287 289 +2 |
Parsing special characters ('>', '<', '&') and also
'+' (for compatibility of output with Asciidoctor)
These special characters are stored in the new `SpecialCharacter`
type and can be converted into HTML entities in the HTML5
and XHTML5 backends. Other backends may decide to display
the values as-is.
This removes the introduction of HTML entities during
attribute substitutions (which would cause troubles for
future backends) and also, removes the need to
the `sanitized` type (an alias for `html.HTML`)
Fixes bytesparadise#729
Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
force-pushed
the
Issue729_parse_special_characters
branch
from
5961664 to
b119698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing special characters ('>', '<', '&') and also
'+' (for compatibility of output with Asciidoctor)
These special characters are stored in the new
SpecialCharactertype and can be converted into HTML entities in the HTML5
and XHTML5 backends. Other backends may decide to display
the values as-is.
This removes the introduction of HTML entities during
attribute substitutions (which would cause troubles for
future backends) and also, removes the need to
the
sanitizedtype (an alias forhtml.HTML)Fixes #729
Signed-off-by: Xavier Coulon [email protected]