refactor(renderer): Use string instead of []byte internally … #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to mark that commit -- integrating this PR will fix #619. |
Codecov Report
@@ Coverage Diff @@
## master #625 +/- ##
==========================================
- Coverage 86.78% 86.77% -0.01%
==========================================
Files 70 70
Lines 4395 4393 -2
==========================================
- Hits 3814 3812 -2
Misses 369 369
Partials 212 212 |
This uses strings.Builder to get more efficiency and reduce copies, but more importantly it gets rid of the need to pipe output through printf "%s" in templates, which makes them cleaner and nicer to work with. Fixes bytesparadise#619
|
Rebased as requested. |
|
thanks @gdamore 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: This PR is based upon the PR for 623, as I anticipate that that PR will be merged first.
This internal refactoring is phase 1, and gets rid of the | printf "%s" nonsense in the templates.
I anticipate doing further refactoring of the templates to make them nicer and easier to work with, and easier to modify. (For example removing Contextual Pipeline intermediate object and the need to do with $Data.)
Note that I did not have to modify any of the test code for this -- there are no changes to outputs.