Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): support cross references to images within tables #1050

Merged

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Jun 20, 2022

Fixes #1049

Signed-off-by: Xavier Coulon [email protected]

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #1050 (efe6d2e) into master (db62762) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1050      +/-   ##
==========================================
+ Coverage   80.53%   80.57%   +0.04%     
==========================================
  Files          85       85              
  Lines        7106     7121      +15     
==========================================
+ Hits         5723     5738      +15     
  Misses        867      867              
  Partials      516      516              

@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              27.2ms ± 2%    27.2ms ± 1%    ~     (p=0.605 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    73.8ms ± 1%    74.0ms ± 1%    ~     (p=0.447 n=10+9)
RealDocumentProcessing/mocking.adoc-2           73.0ms ± 1%    73.2ms ± 1%    ~     (p=0.315 n=10+8)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.6MB ± 0%    10.6MB ± 0%  +0.02%  (p=0.015 n=9+8)
RealDocumentProcessing/vertx-examples.adoc-2    27.8MB ± 0%    27.8MB ± 0%    ~     (p=0.065 n=9+10)
RealDocumentProcessing/mocking.adoc-2           23.7MB ± 0%    23.7MB ± 0%  +0.01%  (p=0.043 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                123k ± 0%      123k ± 0%  +0.01%  (p=0.021 n=9+8)
RealDocumentProcessing/vertx-examples.adoc-2      350k ± 0%      350k ± 0%    ~     (p=0.062 n=9+10)
RealDocumentProcessing/mocking.adoc-2             350k ± 0%      350k ± 0%  +0.00%  (p=0.002 n=10+9)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              27.2ms ± 2%    18.4ms ± 1%  -32.34%  (p=0.000 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    73.8ms ± 1%    52.1ms ± 2%  -29.31%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           73.0ms ± 1%    50.7ms ± 3%  -30.57%  (p=0.000 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.6MB ± 0%     8.8MB ± 0%  -16.86%  (p=0.000 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    27.8MB ± 0%    24.0MB ± 0%  -13.73%  (p=0.000 n=9+10)
RealDocumentProcessing/mocking.adoc-2           23.7MB ± 0%    21.6MB ± 0%   -8.91%  (p=0.000 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                123k ± 0%      106k ± 0%  -13.32%  (p=0.000 n=9+10)
RealDocumentProcessing/vertx-examples.adoc-2      350k ± 0%      305k ± 0%  -12.77%  (p=0.000 n=9+7)
RealDocumentProcessing/mocking.adoc-2             350k ± 0%      326k ± 0%   -6.70%  (p=0.000 n=10+10)

@xcoulon xcoulon merged commit 043f58c into bytesparadise:master Jun 20, 2022
@xcoulon xcoulon deleted the Issue1049_cross_ref_image_within_table branch June 20, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support cross references to image blocks within tables
1 participant