Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): simplify QuotedText rule #1034

Merged
merged 1 commit into from
Jun 4, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Jun 4, 2022

parse attributes only once for escaped and unescaped text

store attributes in current state

Signed-off-by: Xavier Coulon [email protected]

parse attributes only once for escaped and unescaped text

store attributes in current state

Signed-off-by: Xavier Coulon <[email protected]>
@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #1034 (c10dd21) into master (cd41d73) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
+ Coverage   80.29%   80.31%   +0.02%     
==========================================
  Files          86       86              
  Lines        7038     7025      -13     
==========================================
- Hits         5651     5642       -9     
+ Misses        864      862       -2     
+ Partials      523      521       -2     

@github-actions
Copy link

github-actions bot commented Jun 4, 2022

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              24.4ms ± 0%    25.0ms ± 1%  +2.44%  (p=0.000 n=9+8)
RealDocumentProcessing/vertx-examples.adoc-2    73.2ms ± 1%    72.9ms ± 4%    ~     (p=0.353 n=10+10)
RealDocumentProcessing/mocking.adoc-2           72.5ms ± 2%    72.8ms ± 3%    ~     (p=0.842 n=10+9)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.68MB ± 0%    9.68MB ± 0%    ~     (p=0.234 n=9+10)
RealDocumentProcessing/vertx-examples.adoc-2    27.0MB ± 0%    27.0MB ± 0%    ~     (p=0.156 n=9+10)
RealDocumentProcessing/mocking.adoc-2           22.6MB ± 0%    22.6MB ± 0%  +0.00%  (p=0.046 n=9+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                120k ± 0%      120k ± 0%    ~     (p=0.059 n=8+10)
RealDocumentProcessing/vertx-examples.adoc-2      350k ± 0%      350k ± 0%    ~     (p=0.827 n=10+10)
RealDocumentProcessing/mocking.adoc-2             347k ± 0%      347k ± 0%    ~     (p=0.590 n=10+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              24.4ms ± 0%    17.8ms ± 2%  -27.08%  (p=0.000 n=9+10)
RealDocumentProcessing/vertx-examples.adoc-2    73.2ms ± 1%    50.1ms ± 2%  -31.50%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           72.5ms ± 2%    49.7ms ± 2%  -31.50%  (p=0.000 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.68MB ± 0%    8.85MB ± 0%   -8.57%  (p=0.000 n=9+10)
RealDocumentProcessing/vertx-examples.adoc-2    27.0MB ± 0%    24.0MB ± 0%  -11.14%  (p=0.000 n=9+10)
RealDocumentProcessing/mocking.adoc-2           22.6MB ± 0%    21.6MB ± 0%   -4.55%  (p=0.000 n=9+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                120k ± 0%      106k ± 0%  -11.30%  (p=0.000 n=8+10)
RealDocumentProcessing/vertx-examples.adoc-2      350k ± 0%      305k ± 0%  -12.95%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2             347k ± 0%      326k ± 0%   -5.86%  (p=0.000 n=10+10)

@xcoulon xcoulon merged commit b2b04b9 into bytesparadise:master Jun 4, 2022
@xcoulon xcoulon deleted the refactor_attribute_rules branch June 4, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant