Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): delimited block immediately after paragraph #1013

Merged

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented May 2, 2022

do not include raw content within paragraph.

Fixes #1008

Signed-off-by: Xavier Coulon [email protected]

do not include raw content within paragraph.

Fixes bytesparadise#1008

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon force-pushed the Issue1008_paragraph_delimitedblock branch from cf2865c to 35f00eb Compare May 2, 2022 17:16
@github-actions
Copy link

github-actions bot commented May 2, 2022

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              19.9ms ± 3%    20.6ms ± 4%  +3.31%  (p=0.004 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    62.2ms ± 4%    63.5ms ± 8%    ~     (p=0.105 n=10+10)
RealDocumentProcessing/mocking.adoc-2           55.4ms ± 1%    56.4ms ± 2%  +1.80%  (p=0.003 n=9+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.35MB ± 0%    9.35MB ± 0%    ~     (p=0.869 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.5MB ± 0%    26.5MB ± 0%    ~     (p=0.829 n=8+10)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.7MB ± 0%  +0.00%  (p=0.035 n=9+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      113k ± 0%    ~     (p=0.650 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2      341k ± 0%      341k ± 0%    ~     (p=0.216 n=10+10)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      328k ± 0%    ~     (p=0.353 n=7+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              19.9ms ± 3%    17.5ms ± 7%  -11.92%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    62.2ms ± 4%    47.5ms ± 2%  -23.56%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           55.4ms ± 1%    46.8ms ± 3%  -15.63%  (p=0.000 n=9+9)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.35MB ± 0%    8.85MB ± 0%   -5.40%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.5MB ± 0%    24.0MB ± 0%   -9.60%  (p=0.000 n=8+10)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.6MB ± 0%   -0.50%  (p=0.000 n=9+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      106k ± 0%   -6.13%  (p=0.000 n=10+8)
RealDocumentProcessing/vertx-examples.adoc-2      341k ± 0%      305k ± 0%  -10.64%  (p=0.000 n=10+9)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      326k ± 0%   -0.50%  (p=0.000 n=7+10)

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1013 (35f00eb) into master (b8014f8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1013   +/-   ##
=======================================
  Coverage   80.15%   80.15%           
=======================================
  Files          85       85           
  Lines        6863     6863           
=======================================
  Hits         5501     5501           
  Misses        856      856           
  Partials      506      506           

@xcoulon xcoulon merged commit 868aa5e into bytesparadise:master May 2, 2022
@xcoulon xcoulon deleted the Issue1008_paragraph_delimitedblock branch May 2, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad literal block detection
1 participant