Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support list item in list item continuation #837

Closed
xcoulon opened this issue Mar 7, 2021 · 4 comments · Fixed by #868
Closed

Support list item in list item continuation #837

xcoulon opened this issue Mar 7, 2021 · 4 comments · Fixed by #868

Comments

@xcoulon
Copy link
Member

xcoulon commented Mar 7, 2021

Example below fails because the renderer does not expect the "chocolate" list item as a continuation

. cookie
+
image::cookie.png[]
+
. chocolate
+
image::chocolate.png[]
@bwklein
Copy link

bwklein commented Mar 7, 2021

This would be a good test for this too.

. In the table, enter the data shown in <<non-uniform-mesh>>
+
[#non-uniform-mesh]
.Non-Uniform Mesh Parameters
[cols="3*^",options="header"]
|===
|Dir (X,Y,Z) |Num Cells |Size
|X |10 |0.1
|Y |10 |0.1
|Y |5  |0.2
|Z |10 |0.1
|===
+
. Click *OK*

xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Nov 22, 2021
also, verifies that cross references work in list element continuations
(bytesparadise#837)

Fixes bytesparadise#867
Fixes bytesparadise#837

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this issue Nov 22, 2021
also, verifies that cross references work in list element continuations
(#837)

Fixes #867
Fixes #837

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon
Copy link
Member Author

xcoulon commented Nov 22, 2021

This would be a good test for this too.

. In the table, enter the data shown in <<non-uniform-mesh>>
+
[#non-uniform-mesh]
.Non-Uniform Mesh Parameters
[cols="3*^",options="header"]
|===
|Dir (X,Y,Z) |Num Cells |Size
|X |10 |0.1
|Y |10 |0.1
|Y |5  |0.2
|Z |10 |0.1
|===
+
. Click *OK*

it works now: see https://github.com/bytesparadise/libasciidoc/pull/868/files#diff-bafcc96dcdb4000d325d31b556660eac1819e49919348c0f7a33f16000ba7093R183-R246

and thanks for suggesting this, I was able to close a few gaps while testing this case ;)

@bwklein
Copy link

bwklein commented Nov 22, 2021

@xcoulon great! I am going to have to go back and try running some of my files through the processor.

@xcoulon
Copy link
Member Author

xcoulon commented Nov 24, 2021

@xcoulon great! I am going to have to go back and try running some of my files through the processor.

@bwklein awesome! don't hesitate to open issues if you find bugs or other gaps that need to be filled!

@xcoulon xcoulon added this to the v0.7.0 milestone Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants