Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially broken pass-through blocks #746

Closed
pjanx opened this issue Aug 19, 2020 · 4 comments · Fixed by #763
Closed

Partially broken pass-through blocks #746

pjanx opened this issue Aug 19, 2020 · 4 comments · Fixed by #763
Labels
area/parser area/renderer type/bug
Milestone
v0.5.1

Comments

@pjanx
Copy link
Contributor

pjanx commented Aug 19, 2020

On current master (bb8703c)

++++
<input>

<input>
++++

gives

&lt;input&gt;

&lt;input&gt;

whereas at least Asciidoctor renders it as intended.

The blank line appears to cause this issue, as removing it "fixes it".
@xcoulon xcoulon added this to the v0.6.0 milestone Oct 4, 2020
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Oct 4, 2020
@xcoulon
fix(parser): ignore special chars in passthrough blocks
d0ab802 
Fixes bytesparadise#746

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Oct 4, 2020
Merged
xcoulon added a commit that referenced this issue Oct 4, 2020
@xcoulon
fix(parser): ignore special chars in passthrough blocks (#763)
3f4ee89 
Fixes #746

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon
Copy link
Member

xcoulon commented Oct 4, 2020

@pjanx this should work now.
Sorry though, I missed this issue while working on v0.5.0 🤦‍♂️

@pjanx
Copy link
Contributor Author

pjanx commented Oct 4, 2020

Thanks, this was somewhat important to me and pass-throughs are a universal way to work around issues.

It's never too late to start using patch versions. :)

@xcoulon
Copy link
Member

xcoulon commented Oct 4, 2020

fair point! let me release a v0.5.1, then ;)

@xcoulon
Copy link
Member

xcoulon commented Oct 4, 2020

here you are: https://github.com/bytesparadise/libasciidoc/releases/tag/v0.5.1 ;)

@xcoulon xcoulon modified the milestones: v0.6.0, v0.5.1 Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/parser area/renderer type/bug
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging a pull request may close this issue.

fix(parser): ignore special chars in passthrough blocks xcoulon/libasciidoc
2 participants
@xcoulon @pjanx