Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom substitutions on paragraphs #597

Closed
xcoulon opened this issue Jun 12, 2020 · 1 comment · Fixed by #726 or #749
Closed

Custom substitutions on paragraphs #597

xcoulon opened this issue Jun 12, 2020 · 1 comment · Fixed by #726 or #749
Assignees
@xcoulon
Labels
area/parser type/feature
Milestone
v0.7.0

Comments

@xcoulon
Copy link
Member

xcoulon commented Jun 12, 2020

Similar to #558 but for paragraphs.
@xcoulon xcoulon self-assigned this Jun 18, 2020
@xcoulon xcoulon mentioned this issue Jun 22, 2020
Closed
@xcoulon xcoulon added this to the backlog milestone Jun 23, 2020
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jul 14, 2020
@xcoulon
feature(parser): custom subs on paragraphs
5d5a214 
Support for one or more custom substitutions
Starting with Rwline elements which are parsed
and result in other elements. Subsequent substitutions
only apply on the StringElements.
At the end of the substitutions, the lines are preserved

Also, fix issues with single line comments which should not
start with spaces before the `//` marker

Fixes bytesparadise#597

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Jul 14, 2020
Merged
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jul 19, 2020
@xcoulon
feature(parser): custom subs on paragraphs
ec88195 
Support for one or more custom substitutions
Starting with Rwline elements which are parsed
and result in other elements. Subsequent substitutions
only apply on the StringElements.
At the end of the substitutions, the lines are preserved

Also, fix issues with single line comments which should not
start with spaces before the `//` marker

Fixes bytesparadise#597

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jul 19, 2020
@xcoulon
feature(parser): custom subs on paragraphs
89c9149 
Support for one or more custom substitutions
Starting with Rawline elements which are parsed
and result in other elements. Subsequent substitutions
only apply on the StringElements.
At the end of the substitutions, the lines are preserved

Also, fix issues with single line comments which should not
start with spaces before the `//` marker

Fixes bytesparadise#597

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jul 20, 2020
@xcoulon
feature(parser): custom subs on paragraphs
16fbca6 
Support for one or more custom substitutions
Starting with Rawline elements which are parsed
and result in other elements. Subsequent substitutions
only apply on the StringElements.
At the end of the substitutions, the lines are preserved

Also, fix issues with single line comments which should not
start with spaces before the `//` marker

Fixes bytesparadise#597

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jul 20, 2020
@xcoulon
feature(parser): custom subs on paragraphs
dd5d31b 
Support for one or more custom substitutions
Starting with Rawline elements which are parsed
and result in other elements. Subsequent substitutions
only apply on the StringElements.
At the end of the substitutions, the lines are preserved

Also, fix issues with single line comments which should not
start with spaces before the `//` marker

Fixes bytesparadise#597

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jul 21, 2020
@xcoulon
feature(parser): custom subs on paragraphs
884c13a 
Support for one or more custom substitutions
Starting with Rawline elements which are parsed
and result in other elements. Subsequent substitutions
only apply on the StringElements.
At the end of the substitutions, the lines are preserved

Also, fix issues with single line comments which should not
start with spaces before the `//` marker

Fixes bytesparadise#597

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Aug 2, 2020
@xcoulon
feature(parser): custom subs on paragraphs
fd51649 
Support for one or more custom substitutions
Starting with Rawline elements which are parsed
and result in other elements. Subsequent substitutions
only apply on the StringElements.
At the end of the substitutions, the lines are preserved

Also, fix issues with single line comments which should not
start with spaces before the `//` marker

Fixes bytesparadise#597

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Aug 2, 2020
@xcoulon
feature(parser): custom subs on paragraphs
9c77a19 
Support for one or more custom substitutions
Starting with Rawline elements which are parsed
and result in other elements. Subsequent substitutions
only apply on the StringElements.
At the end of the substitutions, the lines are preserved

Also, fix issues with single line comments which should not
start with spaces before the `//` marker

Fixes bytesparadise#597

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this issue Aug 2, 2020
@xcoulon
feature(parser): custom subs on paragraphs (#726)
5dcda32 
Support for one or more custom substitutions
Starting with Rawline elements which are parsed
and result in other elements. Subsequent substitutions
only apply on the `StringElements`.
At the end of the substitutions, the lines are preserved.

Also, attribute substitution is only performed when the element substitution 
is `normal` or `attributes`. In other cases, explicit attribute substitution is needed. 

Also, fix issues with single line comments which should not
start with spaces before the `//` marker.



Fixes #597

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon reopened this Aug 3, 2020
@xcoulon
Copy link
Member Author

xcoulon commented Aug 3, 2020

Reopening as work was incomplete: missing tests on the renderers.
Also, need to deal with HTML entities when custom subs are used

@xcoulon xcoulon mentioned this issue Sep 3, 2020
Closed
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Sep 5, 2020
@xcoulon
feat(parser): custom substitutions on paragraphs
0881f41 
Using multiple substitutions to parse the paragraph content
and support custom substitutions via the `subs` attribute.

Some grammar rules have been simplified. For example, the
content of a quoted text can only be other quoted texts or
plain chararacters.

Using "placeholder" elements to support parsing of complex
elements in which previously elements were identified. For
example, a link may contain quoted text as attributes, quoted
test may contain special characters, etc.

Also, introducing a new `ElementRole` type, since attributes
may contain special characters which would be rendered differently,
depending on the backend.

However, this may need more work in the future (expand to
other attributes with somethig generic?)

Sadly, all these changes also have an impact on the performances,
so further investigation may be required, to see if optimizations
can be found.

Fixes bytesparadise#597

Signed-off-by: Xavier Coulon <[email protected]>

WIP update tests after rebasing

Signed-off-by: Xavier Coulon <[email protected]>

WIP - with quotedtext placeholder

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Sep 5, 2020
Merged
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Sep 5, 2020
@xcoulon
feat(parser): custom substitutions on paragraphs
5e2ed38 
Using multiple substitutions to parse the paragraph content
and support custom substitutions via the `subs` attribute.

Some grammar rules have been simplified. For example, the
content of a quoted text can only be other quoted texts or
plain chararacters.

Using "placeholder" elements to support parsing of complex
elements in which previously elements were identified. For
example, a link may contain quoted text as attributes, quoted
test may contain special characters, etc.

Also, introducing a new `ElementRole` type, since attributes
may contain special characters which would be rendered differently,
depending on the backend.

However, this may need more work in the future (expand to
other attributes with somethig generic?)

Sadly, all these changes also have an impact on the performances,
so further investigation may be required, to see if optimizations
can be found.

Fixes bytesparadise#597

Signed-off-by: Xavier Coulon <[email protected]>

WIP update tests after rebasing

Signed-off-by: Xavier Coulon <[email protected]>

WIP - with quotedtext placeholder

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Sep 5, 2020
@xcoulon
feat(parser): custom substitutions on paragraphs
b1e4bbb 
Using multiple substitutions to parse the paragraph content
and support custom substitutions via the `subs` attribute.

Some grammar rules have been simplified. For example, the
content of a quoted text can only be other quoted texts or
plain chararacters.

Using "placeholder" elements to support parsing of complex
elements in which previously elements were identified. For
example, a link may contain quoted text as attributes, quoted
test may contain special characters, etc.

Also, introducing a new `ElementRole` type, since attributes
may contain special characters which would be rendered differently,
depending on the backend.

However, this may need more work in the future (expand to
other attributes with somethig generic?)

Sadly, all these changes also have an impact on the performances,
so further investigation may be required, to see if optimizations
can be found.

Fixes bytesparadise#597

Signed-off-by: Xavier Coulon <[email protected]>

WIP update tests after rebasing

Signed-off-by: Xavier Coulon <[email protected]>

WIP - with quotedtext placeholder

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this issue Sep 6, 2020
@xcoulon
feat(parser): custom substitutions on paragraphs (#749)
7050c34 
Using multiple substitutions to parse the paragraph content
and support custom substitutions via the `subs` attribute.

Some grammar rules have been simplified. For example, the
content of a quoted text can only be other quoted texts or
plain characters.

Using "placeholder" elements to support parsing of complex
elements in which previously elements were identified. For
example, a link may contain quoted text as attributes, quoted
test may contain special characters, etc.

Also, introducing a new `ElementRole` type, since attributes
may contain special characters which would be rendered differently,
depending on the backend.

However, this may need more work in the future (expand to
other attributes with something generic?)

Sadly, all these changes also have an impact on the performances,
so further investigation may be required, to see if optimizations
can be found.

Fixes #597

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Sep 6, 2020
Closed
This was referenced Sep 29, 2020
Closed
Closed
@xcoulon xcoulon modified the milestones: backlog, v0.7.0 Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/parser type/feature
Projects
None yet
Milestone
v0.7.0
1 participant
@xcoulon