Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser fails on when display parameters followed by extra blank line #493

Closed
gdamore opened this issue Mar 1, 2020 · 1 comment · Fixed by #496
Closed

parser fails on when display parameters followed by extra blank line #493

gdamore opened this issue Mar 1, 2020 · 1 comment · Fixed by #496
Labels
area/parser type/bug type/compatibility
Milestone
v0.3.0

Comments

@gdamore
Copy link
Collaborator

gdamore commented Mar 1, 2020

(Arguably this was an error in the source document, but asciidoctor didn't trip over it.)

I had a document where I had a display like this:

[.text-left]

xref:nng_tls_config_alloc.3tls.adoc[nng_tls_config_alloc(3tls)],
xref:nng_tls_config_auth_mode.3tls.adoc[nng_tls_config_auth_mode(3tls)],
xref:nng_tls_config_ca_chain.3tls.adoc[nng_tls_config_ca_chain(3tls)],
xref:nng_tls_config_own_cert.3tls.adoc[nng_tls_config_own_cert(3tls)],
xref:nng_tls_config_free.3tls.adoc[nng_tls_config_free(3tls)],
xref:nng_tls_config_hold.3tls.adoc[nng_tls_config_hold(3tls)],
xref:nng_tls_config_server_name.3tls.adoc[nng_tls_config_server_name(3tls)],
xref:nng.7.adoc[nng(7)]

When I tried to process with using libasciidoc, the parser fell over on it.

asciidoctor did handle this, and seemed to generate reasonable output.

I've fixed my source document, but I wanted to record this as as it represents a change in behavior.
@xcoulon
Copy link
Member

xcoulon commented Mar 3, 2020

ok, I will take a look at this bug. Thanks for reporting it!

@xcoulon xcoulon added this to the v0.3.0 milestone Mar 3, 2020
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Mar 9, 2020
@xcoulon
fix(parser): allow empty lines between attributes and element
18f5bfa 
One or more empty lines can be inserted between a group of attributes
and their target element

fixes bytesparadise#493

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Mar 9, 2020
Merged
xcoulon added a commit that referenced this issue Mar 9, 2020
@xcoulon
fix(parser): allow empty lines between attributes and element (#496)
4d3ef23 
One or more empty lines can be inserted between a group of attributes
and their target element

fixes #493

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/parser type/bug type/compatibility
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

fix(parser): allow empty lines between attributes and element xcoulon/libasciidoc
2 participants
@xcoulon @gdamore