Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid file inclusion with section level 0 #425

Closed
xcoulon opened this issue Oct 26, 2019 · 0 comments · Fixed by #432
Closed

Invalid file inclusion with section level 0 #425

xcoulon opened this issue Oct 26, 2019 · 0 comments · Fixed by #432
Labels
area/renderer type/bug
Milestone
v0.3.0

Comments

@xcoulon
Copy link
Member

xcoulon commented Oct 26, 2019

eg:

:includedir: ../test/includes

include::{includedir}/grandchild-include.adoc[]

with grandchild-include.adoc content being:

= Grand Child

first line of grandchild

last line of grandchild

produces

instead of

<div class="paragraph">
<p>first line of grandchild</p>
</div>
<div class="paragraph">
<p>last line of grandchild</p>
</div>
@xcoulon xcoulon added this to the v0.3.0 milestone Oct 26, 2019
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Oct 27, 2019
@xcoulon
fix(renderer): do not include section 0 element
b4416ad 
unless there's a relevant element before. Otherwise,
just retain the section elements

fixes bytesparadise#425

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Oct 27, 2019
Merged
xcoulon added a commit that referenced this issue Oct 27, 2019
@xcoulon
fix(renderer): do not include section 0 element (#432)
bfff288 
unless there's a relevant element before. Otherwise,
just retain the section elements

fixes #425

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/renderer type/bug
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

fix(renderer): do not include section 0 element xcoulon/libasciidoc
1 participant
@xcoulon