Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not process include macro in non-asciidoc/non-text files #380

Closed
xcoulon opened this issue Jul 19, 2019 · 0 comments · Fixed by #433
Closed

do not process include macro in non-asciidoc/non-text files #380

xcoulon opened this issue Jul 19, 2019 · 0 comments · Fixed by #433
Labels
area/parser type/feature
Milestone
v0.3.0

Comments

@xcoulon
Copy link
Member

xcoulon commented Jul 19, 2019 •
edited
Loading

If the file to include in an include macro is an asciidoc or a text file (ie, with a .asciidoc, .adoc, .ad, .asc, or .txt extension), then we should proceed with its own include macro. For other files to include, the presence of the include macro should not matter.
@xcoulon xcoulon added this to the v0.3.0 milestone Jul 19, 2019
@xcoulon xcoulon changed the title do not process include macro in non-asciidoc files do not process include macro in non-asciidoc/non-text files Oct 29, 2019
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Oct 29, 2019
@xcoulon
feat(parser): do not further processing inclusions in non-asciidoc files
128e18e 
do not process 'include' macros in non-asciidoc files that are included
in the parent document.

also, move the 'IsAsciidoc' func from 'types' to 'parser' pkg.

fixes bytesparadise#380

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Oct 29, 2019
Merged
xcoulon added a commit that referenced this issue Oct 30, 2019
@xcoulon
feat(parser): do not further processing inclusions in non-asciidoc fi…
c4317a1 
…les (#433)

do not process 'include' macros in non-asciidoc files that are included
in the parent document.

also, move the 'IsAsciidoc' func from 'types' to 'parser' pkg.

fixes #380

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/parser type/feature
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

feat(parser): do not further processing inclusions in non-asciidoc files xcoulon/libasciidoc
1 participant
@xcoulon