Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backtick (monospace text format) issue with other text formatting #354

Closed
shuLhan opened this issue May 14, 2019 · 8 comments · Fixed by #357
Closed

Backtick (monospace text format) issue with other text formatting #354

shuLhan opened this issue May 14, 2019 · 8 comments · Fixed by #357
Assignees
Milestone

Comments

@shuLhan
Copy link
Contributor

shuLhan commented May 14, 2019

Raw Input

`*a`

`_a_`

`a_b`

`a_b_`

`a*b`

`a*b*`

`a~b~`

`a
b`

`a link:/[b]`

Expected HTML output

Using asciidoctor v2.0.9, (the "paragraph" wrapper are removed for clarity),

<p><code>*a</code></p>

<p><code><em>a</em></code></p>

<p><code>a_b</code></p>

<p><code>a_b_</code></p>

<p><code>a*b</code></p>

<p><code>a*b*</code></p>

<p><code>a<sub>b</sub></code></p>

<p><code>a
b</code></p>

<p><code>a <a href="/">b</a></code></p>

Actual HTML output

Using libasciidoc 736a89d, (the "paragraph" wrapper are removed for clarity),

<p>`*a`</p>

<p><code><em>a</em></code></p>

<p>`a_b`</p>

<p>`a<em>b</em>`</p>

<p>`a*b`</p>

<p>`a<strong>b</strong>`</p>

<p>`a<sub>b</sub>`</p>

<p>`a
b`</p>

<p><code>a link:/[b]</code></p>
@xcoulon xcoulon self-assigned this May 14, 2019
@xcoulon xcoulon added this to the v0.3.0 milestone May 14, 2019
@xcoulon
Copy link
Member

xcoulon commented May 14, 2019

Thanks for such a comprehensive report, @shuLhan! 👍
I'll take a look at it.

xcoulon added a commit to xcoulon/libasciidoc that referenced this issue May 18, 2019
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue May 18, 2019
@xcoulon
Copy link
Member

xcoulon commented May 18, 2019

with #357, output is now:

<div class="paragraph">
<p><code>*a</code></p>
</div>

<div class="paragraph">
<p><code><em>a</em></code></p>
</div>

<div class="paragraph">
<p><code>a_b</code></p>
</div>

<div class="paragraph">
<p><code>a_b_</code></p>
</div>

<div class="paragraph">
<p><code>a*b</code></p>
</div>

<div class="paragraph">
<p><code>a*b*</code></p>
</div>

<div class="paragraph">
<p><code>a<sub>b</sub></code></p>
</div>

<div class="paragraph">
<p><code>a
b</code></p>
</div>

<div class="paragraph">
<p><code>a <a href="/">b</a></code></p>
</div>

xcoulon added a commit to xcoulon/libasciidoc that referenced this issue May 18, 2019
xcoulon added a commit that referenced this issue May 18, 2019
@shuLhan
Copy link
Contributor Author

shuLhan commented May 21, 2019

@xcoulon FYI, I think there is an infinite loop after the commit 21f6c7f.
I will try my best to debug it and may report it again later.

@xcoulon
Copy link
Member

xcoulon commented May 22, 2019

@shuLhan would you have an example of Asciidoc file to reproduce, please?

@shuLhan
Copy link
Contributor Author

shuLhan commented May 22, 2019

@xcoulon
Copy link
Member

xcoulon commented May 22, 2019

@xcoulon here is the example of file https://github.com/golang-id/web/blob/master/content/doc/faq/index.adoc

ok, then don't worry, my next PR will fix that problem. I'll merge it soon.

@xcoulon
Copy link
Member

xcoulon commented May 23, 2019

@shuLhan could you give it a try again with the latest changes (#360), please?

@shuLhan
Copy link
Contributor Author

shuLhan commented May 23, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants