Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid generated HTML when listing block contains HTML tags #341

Closed
shuLhan opened this issue May 2, 2019 · 2 comments · Fixed by #345
Closed

Invalid generated HTML when listing block contains HTML tags #341

shuLhan opened this issue May 2, 2019 · 2 comments · Fixed by #345
Milestone
v0.2.0

Comments

@shuLhan
Copy link
Contributor

shuLhan commented May 2, 2019 •
edited
Loading

Update: This issue turn out broader than initial issue titled "Double less-than sign '<<' not displayed correctly on listing block", and that is why there are two cases (to keep history of initial report)

Environment

libasciidoc version 0.2.0.

The expected output is generated using asciidoctor CLI.

First case

Input in asciidoc format,

----
 a<<b
----

Expected output in generated HTML,

<pre>a&lt;&lt;b</pre>

Actual output in generated HTML,

<pre>a&lt;<b< pre="">
</b<></pre>

Second case

Input in asciidoc format,

----
<a>link</a>
----

Expected output in generated HTML format,

<div class="listingblock">
<div class="content">
<pre>&lt;a&gt;link&lt;/a&gt;</pre>
</div>
</div>

Actual output in generated HTML format,

<div class="listingblock">
<div class="content">
<pre><a>link</a></pre>
</div>
<div class="listingblock">
@shuLhan shuLhan changed the title Double less-than sign '<<' not displayed correctly on listing block Error when parsing HTML tag inside listing block May 2, 2019
@shuLhan shuLhan changed the title Error when parsing HTML tag inside listing block Invalid generated HTML when listing block contains HTML tags May 2, 2019
@xcoulon
Copy link
Member

xcoulon commented May 2, 2019

thanks for reporting this issue @shuLhan! I'll look into that

xcoulon added a commit to xcoulon/libasciidoc that referenced this issue May 11, 2019
@xcoulon
fix(renderer): escape content of listing and source blocks
71a4f2a 
in particular, all `<`, `>`, `'` and `"` characters

Fixes bytesparadise#341

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue May 11, 2019
Merged
xcoulon added a commit that referenced this issue May 11, 2019
@xcoulon
fix(renderer): escape content of listing and source blocks (#345)
736a89d 
in particular, all `<`, `>`, `'` and `"` characters

Fixes #341

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon
Copy link
Member

xcoulon commented May 11, 2019

@shuLhan sorry for the delay in fixing this bug. Please let me know if it works for you now. Also, feel free to report other bugs if you find any ;)

@xcoulon xcoulon added this to the v0.2.0 milestone Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

fix(renderer): escape content of listing and source blocks xcoulon/libasciidoc
2 participants
@shuLhan @xcoulon