fix: set Array unexpectedly (#569)

bytedance · Dec 28, 2023 · ec2ab23 · ec2ab23
1 parent 29dfcca
commit ec2ab23
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/ast/node.go b/ast/node.go
@@ -534,10 +534,12 @@ func (self *Node) Set(key string, node Node) (bool, error) {
     if err := node.Check(); err != nil {
         return false, err 
     }
-
+    
     if self.t == _V_NONE || self.t == types.V_NULL {
         *self = NewObject([]Pair{{key, node}})
         return false, nil
+    } else if self.itype() != types.V_OBJECT {
+        return false, ErrUnsupportType
     }
 
     p := self.Get(key)

diff --git a/ast/node_test.go b/ast/node_test.go
@@ -1204,6 +1204,11 @@ func TestNodeGetByPath(t *testing.T) {
 }
 
 func TestNodeSet(t *testing.T) {
+    arr := NewRaw(`[]`)
+    ex, ee := arr.Set("a", NewNumber("-1"))
+    if ex || ee == nil {
+        t.Fatal()
+    }
     empty := Node{}
     err := empty.Add(Node{})
     if err != nil {