Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/react event #20

Closed
wants to merge 2 commits into from
Closed

Fix/react event #20

wants to merge 2 commits into from

Conversation

ponkans
Copy link

@ponkans ponkans commented May 11, 2022

问题

组件使用 magic 处理，react 17 之前，事件不生效。
具体可参考 react 官方 Issues

解决方案

基于 react-shadow-dom-retarget-events 库进行兼容处理

@jerryOnlyZRJ
Copy link
Member

我们之前了解这个问题，只不过框架的兼容不适合将逻辑放在核心包中，这样会增加框架的耦合，比如 Vue 的项目，他们完全不需要引入这部分依赖及逻辑，建议同我们在实际的业务使用中一样，单独放在业务层去处理，或者封装成 magic plugin 解决

@jerryOnlyZRJ
Copy link
Member

这个 MR 我就先关闭啦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChelesteWang ChelesteWang ChelesteWang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ponkans @jerryOnlyZRJ @ChelesteWang