feat: add syncx.Pool #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hchenn
force-pushed
the
feat/syncx
branch
2 times, most recently
from
83e49b2 to
0db792d
Compare
PureWhiteWu
reviewed
Jun 3, 2021
| } | ||
|
|
||
| func init() { | ||
| runtime_registerPoolCleanup(poolCleanup) |
There was a problem hiding this comment.
会不会覆盖官方 sync.Pool 的清理逻辑？
There was a problem hiding this comment.
这里还请评估一下，具体参见 poolCleanup 的实现，我同时 link 了 runtime 的 poolCleanup
There was a problem hiding this comment.
嗯，主要有点担心未来官方的版本逻辑修改了导致出现不可预测问题。不过目前来看应该没啥太大问题。
PureWhiteWu
previously approved these changes
Jun 6, 2021
PureWhiteWu
previously approved these changes
Jun 6, 2021
PureWhiteWu
approved these changes
Jun 6, 2021
zhangyunhao116
approved these changes
Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See README for details.