Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mcache skip manage > 1gb buffer #214

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: mcache skip manage > 1gb buffer #214

wants to merge 4 commits into from

Conversation

joway
Copy link
Collaborator

@joway joway commented Jun 3, 2024 •
edited
Loading

当单个连续内存超过 1GB 时，mcache 极有可能创建双倍的连续内存，进而导致巨大的内存浪费。而这类 case 实际上应该交由 runtime 去管理内存，单纯 cache 提供的性能收益会被内存放大所吞噬。

jayantxie
jayantxie reviewed Jun 3, 2024
View reviewed changes
lang/mcache/mcache.go Outdated Show resolved Hide resolved
jayantxie
jayantxie previously approved these changes Jun 4, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantxie jayantxie jayantxie left review comments

@PureWhiteWu PureWhiteWu Awaiting requested review from PureWhiteWu PureWhiteWu is a code owner

@zhangyunhao116 zhangyunhao116 Awaiting requested review from zhangyunhao116 zhangyunhao116 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joway @jayantxie