Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: donate choleraehyq/pid to gopkg #134

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

choleraehyq
Copy link

@choleraehyq choleraehyq commented Apr 29, 2022

Donate choleraehyq/pid, which is widely used inside bytedance.

Signed-off-by: Cholerae Hu [email protected]

@choleraehyq
Copy link
Author

@choleraehyq choleraehyq changed the title feature: denote choleraehyq/pid to gopkg feature: donate choleraehyq/pid to gopkg Apr 29, 2022
@zhangyunhao116
Copy link
Member

Thanks!
Not sure the pid still needs to be updated after each Go release? if so, I worry that it will make the entire repository unavailable after the Go version update.

lang/pid/goid.go Outdated Show resolved Hide resolved
@choleraehyq
Copy link
Author

Thanks! Not sure the pid still needs to be updated after each Go release? if so, I worry that it will make the entire repository unavailable after the Go version update.

@zhangyunhao116 Yes, currently it needs to be updated after each Go release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants