Add connector doris #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyli1019
reviewed
Oct 24, 2022
| @@ -47,4 +52,8 @@ public interface FakeReaderOptions extends ReaderOptions.BaseReaderOptions { | |||
| ConfigOption<Boolean> USE_BITSAIL_TYPE = | |||
| key(READER_PREFIX + "use_bitsail_type") | |||
| .defaultValue(true); | |||
|
|
|||
| ConfigOption<List<Map<String, String>>> FIXED_COLUMNS = | |||
| key(READER_PREFIX + "fixed_columns") | |||
There was a problem hiding this comment.
what is the meaning of fixed_columns?
There was a problem hiding this comment.
Means the column(s) defined here has fixed value.
Format is:
[ { "name": "column_name", "fixed_value": "a value" } ]
There was a problem hiding this comment.
We need this option because we want some fixed value columns sometimes. For example in doris connector test, the FakeSource needs to produce records with the same partition value(s).
Already add comment to this option.
garyli1019
reviewed
Oct 24, 2022
| .defaultValue("root"); | ||
|
|
||
| ConfigOption<String> PASSWORD = | ||
| key(WRITER_PREFIX + "password") |
There was a problem hiding this comment.
is this field being printed anywhere in the log?
| public class DorisSinkITCase { | ||
|
|
||
| @Test | ||
| public void test() throws Exception { |
There was a problem hiding this comment.
No doris container needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peng Liu [email protected]
Pre-Checklist
Note: Please complete ALL items in the following checklist.
Purpose
Add connectors for doris.
Approaches
Related Issues
N/A
New Behavior (screenshots if needed)
N/A