Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Librasp modify guoyj #634

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Librasp modify guoyj #634

wants to merge 2 commits into from

Conversation

cnguoyj-leminis
Copy link
Collaborator

A similar PR may already be submitted!
Please search among the Pull request before creating one.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

For more information, see the CONTRIBUTING guide.

Summary

This PR fixes/implements the following bugs/features

  • Bug 1
  • Bug 2
  • Feature 1
  • Feature 2
  • Breaking changes

Explain the motivation for making this change. What existing problem does the pull request solve?

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Code formatting

Closing issues

Fixes #

@cnguoyj-leminis cnguoyj-leminis requested a review from yoloyyh June 12, 2024 03:59
for path in parsed_paths.clone() {
let mut path_str = format!("{}{}",dst_root,path.display());
let path_buf: PathBuf = path_str.into();
println!(" {} exist", path_buf.display());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些打印改成跟原先的日志一致吧,可以重定向到rasp.log

println!(" {} exist", path_buf.display());
if path_buf.join(&soname).exists() {
println!("{} exist",soname);
bIsExist = true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果后面依赖库修改了版本,这里会依旧使用旧的so库?是否会有兼容性问题呢?

@yoloyyh yoloyyh self-requested a review July 16, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants