Rust: avoid emitting trailing whitespace #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around what appears to be a bug in rustfmt when generating bindings for wasi-http. If the code is too complex, rustfmt appears to stops formatting, and then abort when it leaves behind trailing whitespace.
|
This is hitting some errors that I don't yet understand. |
|
My guess is that the issue lies somewhere around here where the custom section literal is being emitted. The string literal with escapes may be getting mangled in the wrong way with the new logic in |
alexcrichton
approved these changes
Mar 4, 2024
|
Thanks, that was indeed the spot! |
sunfishcode
added a commit
to sunfishcode/cargo-component
that referenced
this pull request
Mar 4, 2024
Among other things, this pulls in bytecodealliance/wit-bindgen#878, which fixes a bug I'm hitting when using cargo component with wasi-http.
peterhuene
pushed a commit
to bytecodealliance/cargo-component
that referenced
this pull request
Mar 5, 2024
Among other things, this pulls in bytecodealliance/wit-bindgen#878, which fixes a bug I'm hitting when using cargo component with wasi-http.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around what appears to be a bug in rustfmt when generating bindings for wasi-http. If the code is too complex, rustfmt appears to stops formatting, and then abort when it leaves behind trailing whitespace.