Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no_std to wit-bindgen-rt crate. #877

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Add no_std to wit-bindgen-rt crate. #877

merged 1 commit into from
Mar 4, 2024

Conversation

peterhuene
Copy link
Member

We forgot to add this when we refactored wit-bindgen-rt into its own crate.

@peterhuene
Copy link
Member Author

@alexcrichton would it be possible to do a patch release of wit-bindgen-rt with this change to unblock the no_std users of cargo-component?

@peterhuene peterhuene requested a review from alexcrichton March 3, 2024 14:29
alexcrichton
alexcrichton approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'm not sure how best to release this since I'm wary to make two special cases in a row for this crate, I'm more tempted to do an 0.21.0 release to prevent the released versions from all getting out of sync, would that be ok for cargo-component?

@alexcrichton alexcrichton added this pull request to the merge queue Mar 4, 2024
@peterhuene
Copy link
Member Author

@alexcrichton sure that'd be fine.

Merged via the queue into bytecodealliance:main with commit efd511f Mar 4, 2024
12 checks passed
@alexcrichton
Copy link
Member

Ok I've posted a bump to #879

@peterhuene peterhuene deleted the no-std branch March 4, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterhuene @alexcrichton