wit-component: update the tool to expect mangled names. #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates `wit-component` to expect mangled names in imports and exports. Test baselines were updated to use mangled names in the core module.
alexcrichton
approved these changes
Sep 23, 2022
pchickey
pushed a commit
to pchickey/wit-bindgen
that referenced
this pull request
Sep 29, 2022
…codealliance#322)" This reverts commit 6aadac3. We chose not to use this approach to smuggling component type information in core modules. See WebAssembly/component-model#106 (comment) for more details.
alexcrichton
pushed a commit
that referenced
this pull request
Sep 29, 2022
…" (#329) This reverts commit 6aadac3. We chose not to use this approach to smuggling component type information in core modules. See WebAssembly/component-model#106 (comment) for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
wit-componentto expect mangled names in imports and exports.Test baselines were updated to use mangled names in the core module.